[epiphany/mcatanzaro/cppcheck: 3/16] find-toolbar: fix cppcheck warnings



commit db11d4eefbf7c62c877934df25f7423e148f3541
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Sun Nov 17 09:25:24 2019 -0600

    find-toolbar: fix cppcheck warnings
    
    It found some unused instance member variables, and wants us to clarify
    operator precedence here (a good idea).

 embed/ephy-find-toolbar.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/embed/ephy-find-toolbar.c b/embed/ephy-find-toolbar.c
index b850183ed..0404a5f07 100644
--- a/embed/ephy-find-toolbar.c
+++ b/embed/ephy-find-toolbar.c
@@ -48,11 +48,8 @@ struct _EphyFindToolbar {
   guint find_again_source_id;
   guint find_source_id;
   char *find_string;
-  guint preedit_changed : 1;
-  guint prevent_activate : 1;
-  guint activated : 1;
-  guint links_only : 1;
-  guint typing_ahead : 1;
+  gboolean links_only;
+  gboolean typing_ahead;
 };
 
 G_DEFINE_TYPE (EphyFindToolbar, ephy_find_toolbar, HDY_TYPE_SEARCH_BAR)
@@ -191,7 +188,7 @@ found_text_cb (WebKitFindController *controller,
 
   options = webkit_find_controller_get_options (controller);
   /* FIXME: it's not possible to remove the wrap flag, so the status is now always wrapped. */
-  result = options & WEBKIT_FIND_OPTIONS_WRAP_AROUND ? EPHY_FIND_RESULT_FOUNDWRAPPED : 
EPHY_FIND_RESULT_FOUND;
+  result = (options & WEBKIT_FIND_OPTIONS_WRAP_AROUND) ? EPHY_FIND_RESULT_FOUNDWRAPPED : 
EPHY_FIND_RESULT_FOUND;
   set_status (toolbar, result);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]