[gnome-games] database: Remove remains of the metadata table



commit 2581a9059ca772b31877ba5b1d19920c67276528
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Fri Nov 15 01:52:13 2019 +0500

    database: Remove remains of the metadata table
    
    We don't have any metadata anymore, so the table effectively lists uids,
    and during collection loading, every game queries the uid from database.
    
    Just remove it, along with DatabaseGame and DatabaseUid.

 src/database/database-game.vala | 35 ----------------------
 src/database/database-uid.vala  | 66 -----------------------------------------
 src/database/database.vala      | 12 --------
 src/meson.build                 |  2 --
 src/ui/application.vala         |  7 +----
 5 files changed, 1 insertion(+), 121 deletions(-)
---
diff --git a/src/database/database.vala b/src/database/database.vala
index ee1d884b..09638579 100644
--- a/src/database/database.vala
+++ b/src/database/database.vala
@@ -18,13 +18,6 @@ private class Games.Database : Object {
                SELECT EXISTS (SELECT 1 FROM game_resources WHERE uri=$URI LIMIT 1);
        """;
 
-       private const string CREATE_METADATA_TABLE_QUERY = """
-               CREATE TABLE IF NOT EXISTS game_metadata (
-                       uid TEXT PRIMARY KEY NOT NULL,
-                       developer TEXT
-               ) WITHOUT ROWID;
-       """;
-
        public Database (string path) throws Error {
                if (Sqlite.Database.open (path, out database) != Sqlite.OK)
                        throw new DatabaseError.COULDNT_OPEN ("Couldn’t open the database for “%s”.", path);
@@ -63,13 +56,8 @@ private class Games.Database : Object {
                return new DatabaseUriSource (database);
        }
 
-       public DatabaseUid get_uid (Uid uid) {
-               return new DatabaseUid (database, uid);
-       }
-
        private void create_tables () throws Error {
                exec (CREATE_RESOURCES_TABLE_QUERY, null);
-               exec (CREATE_METADATA_TABLE_QUERY, null);
        }
 
        private void exec (string query, Sqlite.Callback? callback) throws Error {
diff --git a/src/meson.build b/src/meson.build
index 8554d080..4935f3f3 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -44,8 +44,6 @@ vala_sources = [
 
   'database/database.vala',
   'database/database-error.vala',
-  'database/database-game.vala',
-  'database/database-uid.vala',
   'database/database-uri-iterator.vala',
   'database/database-uri-source.vala',
 
diff --git a/src/ui/application.vala b/src/ui/application.vala
index bb8dcb34..a9a1e726 100644
--- a/src/ui/application.vala
+++ b/src/ui/application.vala
@@ -209,12 +209,7 @@ public class Games.Application : Gtk.Application {
                init_game_sources ();
                load_game_list.begin ();
                ListStore list_store = new ListStore (typeof (Game));
-               game_collection.game_added.connect ((game) => {
-                       if (database != null)
-                               list_store.append (new DatabaseGame (database, game));
-                       else
-                               list_store.append (game);
-               });
+               game_collection.game_added.connect (game => list_store.append (game));
 
                if (window != null) {
                        window.present_with_time (Gtk.get_current_event_time ());


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]