[orca] Filter out nameless, childless alerts and dialogs from dialog count
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Filter out nameless, childless alerts and dialogs from dialog count
- Date: Wed, 13 Nov 2019 16:41:33 +0000 (UTC)
commit dae42edc195545ce4a417722919bf38a5f0dac4a
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Wed Nov 13 11:41:03 2019 -0500
Filter out nameless, childless alerts and dialogs from dialog count
src/orca/script_utilities.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index d62f6adac..769c5399c 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -2451,8 +2451,11 @@ class Utilities:
isDialog = lambda x: x and x.getRole() in roles or self.isFunctionalDialog(x)
dialogs = [x for x in obj.getApplication() if isDialog(x)]
dialogs.extend([x for x in self.topLevelObject(obj) if isDialog(x)])
- showing = list(filter(self.isShowingAndVisible, dialogs))
- unfocused = list(filter(lambda x: not self.canBeActiveWindow(x), showing))
+
+ isPresentable = lambda x: self.isShowingAndVisible(x) and (x.name or x.childCount)
+ presentable = list(filter(isPresentable, dialogs))
+
+ unfocused = list(filter(lambda x: not self.canBeActiveWindow(x), presentable))
return len(unfocused)
def uri(self, obj):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]