[pitivi] Fix pylint no-method-argument



commit ac4c1c8b40c955ee614f6d3a9479c02c7a5ae103
Author: Alexandru Băluț <alexandru balut gmail com>
Date:   Fri Nov 1 09:01:16 2019 +0100

    Fix pylint no-method-argument

 pitivi/effects.py | 20 ++++++++++----------
 pre-commit.hook   |  1 -
 2 files changed, 10 insertions(+), 11 deletions(-)
---
diff --git a/pitivi/effects.py b/pitivi/effects.py
index 05c1a747..46a472f8 100644
--- a/pitivi/effects.py
+++ b/pitivi/effects.py
@@ -601,6 +601,12 @@ class EffectListWidget(Gtk.Box, Loggable):
 PROPS_TO_IGNORE = ['name', 'qos', 'silent', 'message', 'parent']
 
 
+def create_widget_accumulator_func(ihint, return_accu, handler_return, *args):
+    """Aborts `create_widget` emission if we got a widget."""
+    continue_emission = handler_return is None
+    return continue_emission, handler_return
+
+
 class EffectsPropertiesManager(GObject.Object, Loggable):
     """Provides and caches UIs for editing effects.
 
@@ -608,19 +614,13 @@ class EffectsPropertiesManager(GObject.Object, Loggable):
         app (Pitivi): The app.
     """
 
-    def create_widget_accumulator(*args):
-        """Aborts `create_widget` emission if we got a widget."""
-        handler_return = args[2]
-        if handler_return is None:
-            return True, handler_return
-        return False, handler_return
-
     __gsignals__ = {
-        "create_widget": (GObject.SignalFlags.RUN_LAST, Gtk.Widget, (GstElementSettingsWidget, GES.Effect,),
-                          create_widget_accumulator),
+        "create_widget": (
+            GObject.SignalFlags.RUN_LAST, Gtk.Widget, (GstElementSettingsWidget, GES.Effect,),
+            create_widget_accumulator_func),
         "create_property_widget": (
             GObject.SignalFlags.RUN_LAST, object, (GstElementSettingsWidget, GES.Effect, object, object,),
-            create_widget_accumulator),
+            create_widget_accumulator_func),
     }
 
     def do_create_widget(self, effect_widget, effect):
diff --git a/pre-commit.hook b/pre-commit.hook
index 41b1f1ae..9ca8972e 100755
--- a/pre-commit.hook
+++ b/pre-commit.hook
@@ -14,7 +14,6 @@ export PYTHONPATH=$TOPLEVEL/pitivi/coptimizations/.libs:$PYTHONPATH
 PYLINT_IGNORED_FILES="
 bin/pitivi.in
 pitivi/autoaligner.py
-pitivi/effects.py
 pitivi/medialibrary.py
 pitivi/timeline/elements.py
 pitivi/timeline/timeline.py


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]