GNOME.org
 

[pitivi] Disable pylint too-many-*

commit a2cb257e1a504e7bd90c0298420822e82d30fef6
Author: Alexandru Băluț <alexandru balut gmail com>
Date:   Tue Oct 29 14:59:51 2019 +0100

    Disable pylint too-many-*

 build/flatpak/pitivi-flatpak          | 7 +++----
 pitivi/clipproperties.py              | 3 ---
 pitivi/greeterperspective.py          | 1 -
 pitivi/mainwindow.py                  | 2 --
 pitivi/shortcuts.py                   | 2 +-
 pitivi/tabsmanager.py                 | 1 -
 pitivi/timeline/markers.py            | 1 -
 pitivi/timeline/previewers.py         | 5 -----
 pitivi/undo/markers.py                | 2 +-
 pitivi/utils/custom_effect_widgets.py | 3 +--
 plugins/console/consolebuffer.py      | 3 +--
 tests/test_clipproperties.py          | 2 +-
 tests/test_misc.py                    | 1 -
 tests/test_proxy.py                   | 2 +-
 tests/test_render.py                  | 1 -
 tests/test_timeline_elements.py       | 3 +--
 16 files changed, 10 insertions(+), 29 deletions(-)
---
diff --git a/build/flatpak/pitivi-flatpak b/build/flatpak/pitivi-flatpak
index 5d38b5a0..8dcd0482 100755
--- a/build/flatpak/pitivi-flatpak
+++ b/build/flatpak/pitivi-flatpak
@@ -259,7 +259,6 @@ class FlatpakRepos(FlatpakObject):
         self.repos = {}
         self.update()
 
-    # pylint: disable=too-many-branches
     def update(self):
         self.repos = {}
         if FLATPAK_VERSION["flatpak"] < (1, 1, 2):
@@ -348,7 +347,7 @@ class FlatpakRepos(FlatpakObject):
 
 class FlatpakRepo(FlatpakObject):
 
-    def __init__(self, name, url, desc=None, user=True, repos=None):  # pylint: disable=too-many-arguments
+    def __init__(self, name, url, desc=None, user=True, repos=None):
         FlatpakObject.__init__(self, user=user)
 
         self.name = name
@@ -361,7 +360,7 @@ class FlatpakRepo(FlatpakObject):
 class FlatpakPackage(FlatpakObject):
     """A flatpak app."""
 
-    def __init__(self, name, branch, repo, arch, user=True):  # pylint: disable=too-many-arguments
+    def __init__(self, name, branch, repo, arch, user=True):
         FlatpakObject.__init__(self, user=user)
 
         self.name = name
@@ -416,7 +415,7 @@ class FlatpakPackage(FlatpakObject):
                      comment="Running %s (%s)" % (self.name, self.branch))
 
 
-class PitiviFlatpak:  # pylint: disable=too-many-instance-attributes
+class PitiviFlatpak:
 
     def __init__(self):
         self.name = "Pitivi"
diff --git a/pitivi/clipproperties.py b/pitivi/clipproperties.py
index 6bfeb1be..51943f67 100644
--- a/pitivi/clipproperties.py
+++ b/pitivi/clipproperties.py
@@ -98,7 +98,6 @@ class ClipProperties(Gtk.ScrolledWindow, Loggable):
         return infobar
 
 
-# pylint: disable=too-many-instance-attributes
 class EffectProperties(Gtk.Expander, Loggable):
     """Widget for viewing a list of effects and configuring them.
 
@@ -107,7 +106,6 @@ class EffectProperties(Gtk.Expander, Loggable):
         clip (GES.Clip): The clip being configured.
     """
 
-    # pylint: disable=too-many-statements
     def __init__(self, app, clip_properties):
         Gtk.Expander.__init__(self)
         self.set_expanded(True)
@@ -363,7 +361,6 @@ class EffectProperties(Gtk.Expander, Loggable):
         self.no_effect_infobar.drag_unhighlight()
         self._vbox.drag_unhighlight()
 
-    # pylint: disable=too-many-arguments
     def _drag_data_received_cb(self, widget, drag_context, x, y, selection_data, unused_info, timestamp):
         if not self.clip:
             # Indicate that a drop will not be accepted.
diff --git a/pitivi/greeterperspective.py b/pitivi/greeterperspective.py
index fa47d39b..8d06d612 100644
--- a/pitivi/greeterperspective.py
+++ b/pitivi/greeterperspective.py
@@ -76,7 +76,6 @@ class ProjectInfoRow(Gtk.ListBoxRow):
         return False
 
 
-# pylint: disable=too-many-instance-attributes
 class GreeterPerspective(Perspective):
     """Pitivi's Welcome/Greeter perspective.
 
diff --git a/pitivi/mainwindow.py b/pitivi/mainwindow.py
index caf15b12..f933647b 100644
--- a/pitivi/mainwindow.py
+++ b/pitivi/mainwindow.py
@@ -17,7 +17,6 @@
 # Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 """Pitivi's main window."""
-# pylint: disable=too-many-instance-attributes
 import os
 from gettext import gettext as _
 from urllib.parse import unquote
@@ -67,7 +66,6 @@ GlobalSettings.addConfigOption('lastCurrentVersion',
                                default='')
 
 
-# pylint: disable=too-many-instance-attributes
 class MainWindow(Gtk.ApplicationWindow, Loggable):
     """Pitivi's main window.
 
diff --git a/pitivi/shortcuts.py b/pitivi/shortcuts.py
index f2aeba0f..c1454cff 100644
--- a/pitivi/shortcuts.py
+++ b/pitivi/shortcuts.py
@@ -26,7 +26,7 @@ from pitivi.settings import xdg_config_home
 from pitivi.utils.misc import show_user_manual
 
 
-class ShortcutsManager(GObject.Object):  # pylint: disable=too-many-instance-attributes
+class ShortcutsManager(GObject.Object):
     """Manager storing the shortcuts from all across the app."""
 
     __gsignals__ = {
diff --git a/pitivi/tabsmanager.py b/pitivi/tabsmanager.py
index 966955e1..eb8d7054 100644
--- a/pitivi/tabsmanager.py
+++ b/pitivi/tabsmanager.py
@@ -45,7 +45,6 @@ class BaseTabs(Gtk.Notebook, Loggable):
         notebook_widget_settings.props.gtk_dnd_drag_threshold = 1
         self.connect("create-window", self.__create_window_cb)
 
-    # pylint: disable=arguments-differ
     def append_page(self, child_name, child, label):
         Gtk.Notebook.append_page(self, child, label)
         self._set_child_properties(child, label)
diff --git a/pitivi/timeline/markers.py b/pitivi/timeline/markers.py
index c7cca804..2b6eb83f 100644
--- a/pitivi/timeline/markers.py
+++ b/pitivi/timeline/markers.py
@@ -27,7 +27,6 @@ from pitivi.utils.ui import SPACING
 MARKER_WIDTH = 10
 
 
-# pylint: disable=too-many-instance-attributes
 class Marker(Gtk.EventBox, Loggable):
     """Widget representing a marker."""
 
diff --git a/pitivi/timeline/previewers.py b/pitivi/timeline/previewers.py
index 38120097..2d88980a 100644
--- a/pitivi/timeline/previewers.py
+++ b/pitivi/timeline/previewers.py
@@ -131,7 +131,6 @@ class TeedThumbnailBin(PreviewerBin):
 
         return False
 
-    # pylint: disable=arguments-differ
     def do_post_message(self, message):
         if message.type == Gst.MessageType.ELEMENT and \
                 message.src == self.gdkpixbufsink:
@@ -157,7 +156,6 @@ class TeedThumbnailBin(PreviewerBin):
             raise AttributeError('unknown property %s' % prop.name)
 
 
-# pylint: disable=too-many-instance-attributes
 class WaveformPreviewer(PreviewerBin):
     """Bin to generate and save waveforms as a .npy file."""
 
@@ -210,7 +208,6 @@ class WaveformPreviewer(PreviewerBin):
         else:
             raise AttributeError('unknown property %s' % prop.name)
 
-    # pylint: disable=arguments-differ
     def do_post_message(self, message):
         if message.type == Gst.MessageType.ELEMENT and \
                 message.src == self.level and \
@@ -798,7 +795,6 @@ class AssetPreviewer(Previewer, Loggable):
             self.pipeline.set_state(Gst.State.READY)
 
 
-# pylint: disable=too-many-ancestors
 class VideoPreviewer(Gtk.Layout, AssetPreviewer, Zoomable):
     """A video previewer widget, drawing thumbnails.
 
@@ -1215,7 +1211,6 @@ class AudioPreviewer(Gtk.Layout, Previewer, Zoomable, Loggable):
             return True
         return False
 
-    # pylint: disable=arguments-differ,too-many-locals
     def do_draw(self, context):
         if not self.samples:
             # Nothing to draw.
diff --git a/pitivi/undo/markers.py b/pitivi/undo/markers.py
index e9d727e2..4867c64e 100644
--- a/pitivi/undo/markers.py
+++ b/pitivi/undo/markers.py
@@ -69,7 +69,7 @@ class MarkerListObserver(Loggable):
         self.action_log.push(action)
 
 
-# pylint: disable=abstract-method, too-many-ancestors
+# pylint: disable=abstract-method
 class MarkerAction(UndoableAutomaticObjectAction):
     """Base class for marker actions."""
 
diff --git a/pitivi/utils/custom_effect_widgets.py b/pitivi/utils/custom_effect_widgets.py
index 041d4fb9..56924434 100644
--- a/pitivi/utils/custom_effect_widgets.py
+++ b/pitivi/utils/custom_effect_widgets.py
@@ -17,7 +17,6 @@
 # Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 """Utility methods for custom effect UI."""
-# pylint: disable=too-many-statements
 import os
 from colorsys import rgb_to_hsv
 from types import MethodType
@@ -184,7 +183,7 @@ def create_custom_alpha_prop_widget(unused_element_setting_widget, unused_elemen
     return None
 
 
-# pylint: disable=invalid-name, too-many-locals, too-many-arguments
+# pylint: disable=invalid-name
 def create_3point_color_balance_widget(effect_prop_manager, element_setting_widget, element):
     """Creates a widget for the `frei0r-filter-3-point-color-balance` effect."""
     ui_path = os.path.join(CUSTOM_WIDGETS_DIR, "frei0r-filter-3-point-color-balance.ui")
diff --git a/plugins/console/consolebuffer.py b/plugins/console/consolebuffer.py
index 98bb4a4b..7a0f8564 100644
--- a/plugins/console/consolebuffer.py
+++ b/plugins/console/consolebuffer.py
@@ -77,7 +77,6 @@ class ConsoleHistory(GObject.Object):
 
 
 class ConsoleBuffer(Gtk.TextBuffer):
-    # pylint: disable=too-many-instance-attributes
 
     def __init__(self, namespace, welcome_message=""):
         Gtk.TextBuffer.__init__(self)
@@ -173,7 +172,7 @@ class ConsoleBuffer(Gtk.TextBuffer):
 
     def get_autocompletion_matches(self, input_text):
         """Returns possible matches for autocompletion."""
-        # pylint: disable=bare-except, eval-used, too-many-branches, too-many-locals
+        # pylint: disable=bare-except, eval-used
         # Try to get the possible full object to scan.
         # For example, if input_text is "func(circle.ra", we obtain "circle.ra".
         identifiers = re.findall(r"[_A-Za-z][\w\.]*\w$", input_text)
diff --git a/tests/test_clipproperties.py b/tests/test_clipproperties.py
index 03b683a2..c638c9b7 100644
--- a/tests/test_clipproperties.py
+++ b/tests/test_clipproperties.py
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 """Tests for the pitivi.clipproperties module."""
-# pylint: disable=protected-access,no-self-use,too-many-locals
+# pylint: disable=protected-access,no-self-use
 from unittest import mock
 
 from gi.repository import Gtk
diff --git a/tests/test_misc.py b/tests/test_misc.py
index b80ad6dc..0df3727d 100644
--- a/tests/test_misc.py
+++ b/tests/test_misc.py
@@ -32,7 +32,6 @@ from tests import common
 class MiscMethodsTest(common.TestCase):
     """Tests methods in utils.misc module."""
 
-    # pylint: disable=too-many-arguments
     def check_pixbuf_scaling(self, pixbuf_width, pixbuf_height,
                              width, height,
                              expected_width, expected_height):
diff --git a/tests/test_proxy.py b/tests/test_proxy.py
index d52b50fd..771dd3ff 100644
--- a/tests/test_proxy.py
+++ b/tests/test_proxy.py
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 """Tests for the utils.proxy module."""
-# pylint: disable=protected-access,too-many-arguments
+# pylint: disable=protected-access
 from unittest import mock
 
 from gi.repository import GES
diff --git a/tests/test_render.py b/tests/test_render.py
index ef66f794..4bc7ef32 100644
--- a/tests/test_render.py
+++ b/tests/test_render.py
@@ -18,7 +18,6 @@
 # Boston, MA 02110-1301, USA.
 """Tests for the render module."""
 # pylint: disable=protected-access,no-self-use
-# pylint: disable=too-many-locals
 import os
 import tempfile
 from unittest import mock
diff --git a/tests/test_timeline_elements.py b/tests/test_timeline_elements.py
index 619b26d6..5b70c765 100644
--- a/tests/test_timeline_elements.py
+++ b/tests/test_timeline_elements.py
@@ -17,7 +17,7 @@
 # Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 """Tests for the timeline.elements module."""
-# pylint: disable=protected-access,no-self-use,too-many-locals
+# pylint: disable=protected-access,no-self-use
 from unittest import mock
 
 from gi.overrides import GObject
@@ -118,7 +118,6 @@ class TestKeyframeCurve(BaseTestTimeline):
             values = [item.timestamp for item in control_source.get_all()]
             self.assertEqual(values, [inpoint, inpoint + duration])
 
-    # pylint: disable=too-many-statements
     def check_keyframe_ui_toggle(self, ges_clip, timeline_container):
         """Checks keyframes toggling by click events."""
         timeline = timeline_container.timeline
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]