[pitivi] Fix pylint consider...
- From: Thibault Saunier <tsaunier src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pitivi] Fix pylint consider...
- Date: Mon, 11 Nov 2019 22:05:29 +0000 (UTC)
commit 0aeca66be827cfe21cd9866094a85c9582c4144c
Author: Alexandru Băluț <alexandru balut gmail com>
Date: Sun Oct 27 06:41:21 2019 +0100
Fix pylint consider...
pitivi/project.py | 4 ++--
pitivi/render.py | 22 +++++++++++-----------
pitivi/timeline/elements.py | 1 +
pitivi/utils/loggable.py | 2 +-
pitivi/utils/widgets.py | 4 ++--
5 files changed, 17 insertions(+), 16 deletions(-)
---
diff --git a/pitivi/project.py b/pitivi/project.py
index 5e51626f..89d2e20d 100644
--- a/pitivi/project.py
+++ b/pitivi/project.py
@@ -1401,8 +1401,8 @@ class Project(Loggable, GES.Project):
self._ensureLayer()
if self.uri:
- self.loading_assets = set([asset for asset in self.loading_assets if
- self.app.proxy_manager.is_asset_queued(asset)])
+ self.loading_assets = {asset for asset in self.loading_assets
+ if self.app.proxy_manager.is_asset_queued(asset)}
if self.loading_assets:
self.debug("The following assets are still being transcoded: %s."
diff --git a/pitivi/render.py b/pitivi/render.py
index 702f1b5e..44a63ae3 100644
--- a/pitivi/render.py
+++ b/pitivi/render.py
@@ -159,19 +159,19 @@ class Encoders(Loggable):
for muxer in useless_muxers:
self.muxers.remove(muxer)
- self.factories_by_name = dict([(fact.get_name(), fact)
- for fact in self.muxers + self.aencoders + self.vencoders])
+ self.factories_by_name = {fact.get_name(): fact
+ for fact in self.muxers + self.aencoders + self.vencoders}
good_muxers, good_aencoders, good_vencoders = zip(*self.SUPPORTED_ENCODERS_COMBINATIONS)
- self.supported_muxers = set([muxer
- for muxer in self.muxers
- if muxer.get_name() in good_muxers])
- self.supported_aencoders = set([encoder
- for encoder in self.aencoders
- if encoder.get_name() in good_aencoders])
- self.supported_vencoders = set([encoder
- for encoder in self.vencoders
- if encoder.get_name() in good_vencoders])
+ self.supported_muxers = {muxer
+ for muxer in self.muxers
+ if muxer.get_name() in good_muxers}
+ self.supported_aencoders = {encoder
+ for encoder in self.aencoders
+ if encoder.get_name() in good_aencoders}
+ self.supported_vencoders = {encoder
+ for encoder in self.vencoders
+ if encoder.get_name() in good_vencoders}
self.default_muxer, \
self.default_audio_encoder, \
diff --git a/pitivi/timeline/elements.py b/pitivi/timeline/elements.py
index 0044eb92..921509a3 100644
--- a/pitivi/timeline/elements.py
+++ b/pitivi/timeline/elements.py
@@ -284,6 +284,7 @@ class KeyframeCurve(FigureCanvas, Loggable):
if event.guiEvent.type == Gdk.EventType._2BUTTON_PRESS:
index = result[1]['ind'][0]
+ # pylint: disable=consider-using-in
if index == 0 or index == len(offsets) - 1:
# It's an edge keyframe. These should not be removed.
return
diff --git a/pitivi/utils/loggable.py b/pitivi/utils/loggable.py
index 6939fe99..c88d4c97 100644
--- a/pitivi/utils/loggable.py
+++ b/pitivi/utils/loggable.py
@@ -917,7 +917,7 @@ def outputToFiles(stdout=None, stderr=None):
debug('log', 'installing SIGHUP handler')
from . import signal
handler = signal.signal(signal.SIGHUP, sighup)
- if handler == signal.SIG_DFL or handler == signal.SIG_IGN:
+ if handler in (signal.SIG_DFL, signal.SIG_IGN):
_old_hup_handler = None
else:
_old_hup_handler = handler
diff --git a/pitivi/utils/widgets.py b/pitivi/utils/widgets.py
index f91d43cc..658f48e3 100644
--- a/pitivi/utils/widgets.py
+++ b/pitivi/utils/widgets.py
@@ -699,7 +699,7 @@ class GstElementSettingsWidget(Gtk.Box, Loggable):
def deactivate_keyframe_toggle_buttons(self):
"""Makes sure the keyframe togglebuttons are deactivated."""
self.log("Deactivating all keyframe toggle buttons")
- for keyframe_button in self.__widgets_by_keyframe_button.keys():
+ for keyframe_button in self.__widgets_by_keyframe_button:
if keyframe_button.get_active():
# Deactivate the button. The only effect should be that
# the keyframe curve will control again the default property.
@@ -1013,7 +1013,7 @@ class GstElementSettingsWidget(Gtk.Box, Loggable):
self.log("keyframes togglebutton clicked for %s", prop)
active = keyframe_button.get_active()
# Now change the state of the *other* togglebuttons.
- for toggle_keyframe_button in self.__widgets_by_keyframe_button.keys():
+ for toggle_keyframe_button in self.__widgets_by_keyframe_button:
if toggle_keyframe_button != keyframe_button:
# Don't use set_active directly on the buttons; doing so will
# fire off signals that will toggle the others/confuse the UI
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]