[gnome-music/wip/mschraal/grilo-disable-online-search-3-34] coregrilo: Do not search online sources by default



commit e8c59acf1d9c78f01fc24abd596bd2071a739f3b
Author: Marinus Schraal <mschraal gnome org>
Date:   Fri Nov 8 21:23:41 2019 +0100

    coregrilo: Do not search online sources by default
    
    On search Grilo would search online sources by default as well. This is
    unwanted as it is a privacy issue.
    
    Currently Music has no UI to enable/disable this by user request, go the
    safe route and disable it for stable release.
    
    Closes #317

 gnomemusic/coregrilo.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/gnomemusic/coregrilo.py b/gnomemusic/coregrilo.py
index 52c62003..1b53d886 100644
--- a/gnomemusic/coregrilo.py
+++ b/gnomemusic/coregrilo.py
@@ -139,7 +139,8 @@ class CoreGrilo(GObject.GObject):
         elif (source.props.source_id not in self._search_wrappers.keys()
                 and source.props.source_id not in self._wrappers.keys()
                 and source.get_supported_media() & Grl.MediaType.AUDIO
-                and source.supported_operations() & Grl.SupportedOps.SEARCH):
+                and source.supported_operations() & Grl.SupportedOps.SEARCH
+                and "net:internet" not in source.props.source_tags):
             self._search_wrappers[source.props.source_id] = GrlSearchWrapper(
                 source, self._coremodel, self._coreselection, self)
             print("search source", source)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]