[mutter] window: Warn if O-R window workspace state is used

[Marco Trevisan <marcotrevi src gnome org>]

commit 2644e54c514377009a9d4d747874a55b387c6beb
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date:   Tue Oct 29 17:48:00 2019 +0100

    window: Warn if O-R window workspace state is used
    
    Override-redirect windows have no workspace by default, and can't be parent
    of a top-level window, so we must check that the parent window is not an
    O-R one when setting the workspace state.
    
    https://gitlab.gnome.org/GNOME/mutter/merge_requests/895

 src/core/window.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/src/core/window.c b/src/core/window.c
index b7894ecbb..8b8c8aad5 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -1305,6 +1305,7 @@ _meta_window_shared_new (MetaDisplay         *display,
                       "Putting window %s on same workspace as parent %s\n",
                       window->desc, window->transient_for->desc);
 
+          g_warn_if_fail (!window->transient_for->override_redirect);
           set_workspace_state (window,
                                should_be_on_all_workspaces (window->transient_for),
                                window->transient_for->workspace);