[gimp] Replace finite() with isfinite() by default

[Alex Samorukov <asamorukov src gnome org>]

commit 2cb0493b2f763f1241d448d89cba844ac4124eba
Author: Alex Samorukov <samm net-art cz>
Date:   Thu Nov 7 09:09:22 2019 +0000

    Replace finite() with isfinite() by default
    
    This is part of the C standard also also causing warning on macOS.
    
    (cherry picked from commit 04997fc0ae852f4db9561611c7615da07cdff8a5)

 app/core/gimp-transform-resize.c |  6 +++---
 app/core/gimpcurve-map.c         |  6 +++---
 configure.ac                     | 28 ++++++++++++++++++----------
 pdb/groups/image.pdb             |  6 +++---
 4 files changed, 27 insertions(+), 19 deletions(-)
---
diff --git a/app/core/gimp-transform-resize.c b/app/core/gimp-transform-resize.c
index 50e44d6f4a..dffc133274 100644
--- a/app/core/gimp-transform-resize.c
+++ b/app/core/gimp-transform-resize.c
@@ -31,10 +31,10 @@
 #include "gimp-utils.h"
 
 
-#if defined (HAVE_FINITE)
-#define FINITE(x) finite(x)
-#elif defined (HAVE_ISFINITE)
+#if defined (HAVE_ISFINITE)
 #define FINITE(x) isfinite(x)
+#elif defined (HAVE_FINITE)
+#define FINITE(x) finite(x)
 #elif defined (G_OS_WIN32)
 #define FINITE(x) _finite(x)
 #else
diff --git a/app/core/gimpcurve-map.c b/app/core/gimpcurve-map.c
index 604d4ecb5d..bd39b27a71 100644
--- a/app/core/gimpcurve-map.c
+++ b/app/core/gimpcurve-map.c
@@ -30,10 +30,10 @@
 #include "gimpcurve-map.h"
 
 
-#if defined (HAVE_FINITE)
-#define FINITE(x) finite(x)
-#elif defined (HAVE_ISFINITE)
+#if defined (HAVE_ISFINITE)
 #define FINITE(x) isfinite(x)
+#elif defined (HAVE_FINITE)
+#define FINITE(x) finite(x)
 #elif defined (G_OS_WIN32)
 #define FINITE(x) _finite(x)
 #else
diff --git a/configure.ac b/configure.ac
index a4860d5c66..532c7ebfbf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1020,7 +1020,7 @@ AC_RUN_IFELSE(
      [AC_MSG_RESULT])],
   [AC_MSG_RESULT()])
 
-# Check for finite or isfinite
+# Check for finite
 AC_CHECK_FUNCS(finite, , [
   AC_MSG_CHECKING(for finite in <math.h>)
   AC_LINK_IFELSE(
@@ -1029,15 +1029,23 @@ AC_CHECK_FUNCS(finite, , [
       [[double f = 0.0; finite (f)]])],
     [AC_DEFINE(HAVE_FINITE, 1)
      AC_MSG_RESULT(yes)],
-    [AC_MSG_RESULT(no)
-     AC_MSG_CHECKING(for isfinite in <math.h>)
-     AC_LINK_IFELSE(
-       [AC_LANG_PROGRAM(
-         [[#include <math.h>]],
-         [[float f = 0.0; isfinite(f)]])],
-       [AC_DEFINE([HAVE_ISFINITE],[1],[Define to 1 if you have the isfinite function.])
-        AC_MSG_RESULT(yes)],
-       [AC_MSG_RESULT(no)])])])
+    [AC_MSG_RESULT(no)])
+  ]
+)
+
+# Check for isfinite
+AC_CHECK_FUNCS(isfinite, , [
+  AC_MSG_CHECKING(for isfinite in <math.h>)
+  AC_LINK_IFELSE(
+    [AC_LANG_PROGRAM(
+      [[#include <math.h>]],
+      [[double f = 0.0; isfinite (f)]])],
+    [AC_DEFINE(HAVE_ISFINITE, 1)
+     AC_MSG_RESULT(yes)],
+    [AC_MSG_RESULT(no)])
+  ]
+)
+
 AC_SUBST(HAVE_FINITE)
 AC_SUBST(HAVE_ISFINITE)
 
diff --git a/pdb/groups/image.pdb b/pdb/groups/image.pdb
index c3e347c6cf..08c4a66ed5 100644
--- a/pdb/groups/image.pdb
+++ b/pdb/groups/image.pdb
@@ -2888,10 +2888,10 @@ CODE
 
 
 $extra{app}->{code} = <<'CODE';
-#if defined (HAVE_FINITE)
-#define FINITE(x) finite(x)
-#elif defined (HAVE_ISFINITE)
+#if defined (HAVE_ISFINITE)
 #define FINITE(x) isfinite(x)
+#elif defined (HAVE_FINITE)
+#define FINITE(x) finite(x)
 #elif defined (G_OS_WIN32)
 #define FINITE(x) _finite(x)
 #else