[evolution-rss] Fix use-after-free under rss_ep_need_proxy_http()



commit a5622e381b8209b733d84de5ef84fcfadb49b5ea
Author: Milan Crha <mcrha redhat com>
Date:   Tue Nov 5 17:04:49 2019 +0100

    Fix use-after-free under rss_ep_need_proxy_http()

 src/network-soup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/src/network-soup.c b/src/network-soup.c
index 3a2abbd..2d7ee26 100644
--- a/src/network-soup.c
+++ b/src/network-soup.c
@@ -85,7 +85,6 @@ typedef struct {
        gpointer cb2;
        gpointer cbdata2;
        gchar *url;
-       gchar *host;
        SoupAddress *addr;
        pCallback callback;
        gpointer data;
@@ -356,7 +355,7 @@ rss_resolve_callback (SoupAddress *addr, guint status, gpointer data)
        STNET *stnet = (STNET *)data;
        SoupURI *proxy_uri = NULL;
        if (status == SOUP_STATUS_OK) {
-               if (rss_ep_need_proxy_http (proxy, stnet->host, stnet->addr)) {
+               if (rss_ep_need_proxy_http (proxy, soup_address_get_name (stnet->addr), stnet->addr)) {
 #if (DATASERVER_VERSION >=2026000)
                        proxy_uri = e_proxy_peek_uri_for (proxy, stnet->url);
 #else
@@ -433,7 +432,6 @@ proxify_session_async(EProxy *proxy, STNET *stnet)
 #endif
        case 2:
                su = soup_uri_new (stnet->url);
-               stnet->host = su->host;
                if (su) {
                        if (su->scheme == SOUP_URI_SCHEME_HTTPS) {
                                if (rss_ep_need_proxy_https (proxy, su->host)) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]