[geary/mjog/fix-null-message-ids: 2/4] ComposerWidget: Don't add invalid Message-ID to In-Reply-To
- From: Michael Gratton <mjog src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geary/mjog/fix-null-message-ids: 2/4] ComposerWidget: Don't add invalid Message-ID to In-Reply-To
- Date: Fri, 1 Nov 2019 05:10:00 +0000 (UTC)
commit e18c8fae93db2fa08ff215ca48353a99326da66f
Author: Michael Gratton <mike vee net>
Date: Fri Nov 1 15:39:35 2019 +1100
ComposerWidget: Don't add invalid Message-ID to In-Reply-To
Although Message-ID is usually present, it may not be. If not, the
composer should not be added a null id to the In-Reply-To field.
src/client/composer/composer-widget.vala | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/client/composer/composer-widget.vala b/src/client/composer/composer-widget.vala
index 28cdf959..9c4878ea 100644
--- a/src/client/composer/composer-widget.vala
+++ b/src/client/composer/composer-widget.vala
@@ -1155,8 +1155,10 @@ public class ComposerWidget : Gtk.EventBox, Geary.BaseInterface {
this.to_entry.modified = this.cc_entry.modified = false;
}
- in_reply_to.add(referred.message_id);
- referred_ids.add(referred.id);
+ if (referred.message_id != null) {
+ this.in_reply_to.add(referred.message_id);
+ }
+ this.referred_ids.add(referred.id);
}
public CloseStatus should_close() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]