[gimp] app: do not crash when an extension has no description tag.



commit 400b5646489a69767ba498648fc3be202724740b
Author: Jehan <jehan girinstud io>
Date:   Mon May 27 14:16:55 2019 +0200

    app: do not crash when an extension has no description tag.

 app/core/gimpextension.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/app/core/gimpextension.c b/app/core/gimpextension.c
index 5675ca97f7..89f929b6a5 100644
--- a/app/core/gimpextension.c
+++ b/app/core/gimpextension.c
@@ -274,6 +274,7 @@ gimp_extension_get_markup_description (GimpExtension *extension)
       NULL, /*  passthrough */
       NULL  /*  error       */
     };
+  const gchar *description;
 
   GimpXmlParser *xml_parser;
   gchar         *markup = NULL;
@@ -286,9 +287,9 @@ gimp_extension_get_markup_description (GimpExtension *extension)
   state.unnumbered_list = FALSE;
 
   xml_parser  = gimp_xml_parser_new (&appstream_text_parser, &state);
-  if (! gimp_xml_parser_parse_buffer (xml_parser,
-                                      gimp_extension_get_description (extension),
-                                      -1, &error))
+  description = gimp_extension_get_description (extension);
+  if (description &&
+      ! gimp_xml_parser_parse_buffer (xml_parser, description, -1, &error))
     {
       g_printerr ("%s: %s\n", G_STRFUNC, error->message);
       g_error_free (error);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]