[gnome-boxes/wip/dont-crash-gl: 1/2] spice-display: Don't crash when taking screenshots with GL
- From: Felipe Borges <felipeborges src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes/wip/dont-crash-gl: 1/2] spice-display: Don't crash when taking screenshots with GL
- Date: Mon, 27 May 2019 07:00:27 +0000 (UTC)
commit 2e220617c754f9163fda7ff0ecbe51b71ad5dca7
Author: Felipe Borges <felipeborges gnome org>
Date: Fri May 24 15:36:33 2019 +0200
spice-display: Don't crash when taking screenshots with GL
Boxes crashes when taking screenshots (calling spice_display_get_pixbuf ()
when GL (virgl) is enabled. This is a known Mesa issue, reported
at https://bugs.freedesktop.org/106811
This fix is a workaround (screenshots are not working for virgl
3d accelerated VMs) and should be reverted once the issues are
fixed in Mesa.
This has been initially reported as #311
src/spice-display.vala | 6 ++++++
1 file changed, 6 insertions(+)
---
diff --git a/src/spice-display.vala b/src/spice-display.vala
index f5d6e7bd..5223549a 100644
--- a/src/spice-display.vala
+++ b/src/spice-display.vala
@@ -193,6 +193,12 @@ public override void set_enable_audio (bool enable) {
if (!display.ready)
return null;
+ /* FIXME: This is a temporary workaround for a mesa issue that causes
+ * Boxes to crash when calling spice_display_get_pixbuf ();
+ * See https://bugs.freedesktop.org/106811 */
+ if ((machine as LibvirtMachine).acceleration_3d)
+ return null;
+
return display.get_pixbuf ();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]