[epiphany/mcatanzaro/web-apps-again-again-again: 5/9] profile-migrator: add FIXME comment
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/web-apps-again-again-again: 5/9] profile-migrator: add FIXME comment
- Date: Fri, 24 May 2019 20:54:21 +0000 (UTC)
commit de06fee0be08d6a81a0de5a7aa0f9081ae8045e9
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Fri May 24 14:33:01 2019 -0500
profile-migrator: add FIXME comment
The legacy profile dir just returns the current profile dir, or the
legacy default profile dir when run without a profile dir. That's
obviously not correct since the legacy profile dir is not necessarily
the current profile dir. It leads to some harmless but unexpected
behavior, and it's fragile. Sadly this is not straightforward to
implement correctly, so just add a FIXME for now.
src/profile-migrator/ephy-profile-migrator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/src/profile-migrator/ephy-profile-migrator.c b/src/profile-migrator/ephy-profile-migrator.c
index f87feffed..63d57eee3 100644
--- a/src/profile-migrator/ephy-profile-migrator.c
+++ b/src/profile-migrator/ephy-profile-migrator.c
@@ -74,7 +74,8 @@ legacy_profile_dir (void)
static char *dir = NULL;
if (dir == NULL)
{
- /* If this isn't actually a legacy dir it starts at a later migrating step anyway */
+ /* FIXME: This is fragile and not correct.
+ */
if (profile_dir != NULL)
dir = profile_dir;
else
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]