[libgda: 1/2] Fixing bug error check statement



commit 0370ebf5cf03d26deaf346603a82665687f2aea9
Author: Pavlo Solntsev <p sun fun gmail com>
Date:   Thu Apr 18 08:32:02 2019 -0500

    Fixing bug error check statement
    
    g_return_... for GError were removed from:
    gda_connection_open_from_dsn
    gda_connection_open_from_dsn_name
    gda_connection_new_from_dsn
    gda_connection_new_from_dsn_name

 libgda/gda-connection.c | 4 ----
 1 file changed, 4 deletions(-)
---
diff --git a/libgda/gda-connection.c b/libgda/gda-connection.c
index 6a78f0e0b..a10d22f3c 100644
--- a/libgda/gda-connection.c
+++ b/libgda/gda-connection.c
@@ -939,7 +939,6 @@ gda_connection_new_from_dsn_name (const gchar *dsn_name,
        gchar *real_auth_string = NULL;
 
        g_return_val_if_fail (dsn_name && *dsn_name, NULL);
-  g_return_val_if_fail (error == NULL || *error != NULL, NULL);
 
        gda_dsn_split (dsn_name, &real_dsn, &user, &pass);
        if (!real_dsn) {
@@ -1044,7 +1043,6 @@ gda_connection_new_from_dsn (GdaDsnInfo *dsn,
 
   g_return_val_if_fail (dsn, NULL);
   g_return_val_if_fail (dsn->cnc_string, NULL);
-  g_return_val_if_fail (error == NULL || *error != NULL, NULL);
 
 /* try to find provider */
   if (!dsn->provider)
@@ -1092,7 +1090,6 @@ gda_connection_open_from_dsn_name (const gchar *dsn_name,
   GdaConnection *cnc = NULL;
 
   g_return_val_if_fail (dsn_name && *dsn_name, NULL);
-  g_return_val_if_fail (error == NULL || *error != NULL, NULL);
 
   cnc = gda_connection_new_from_dsn_name (dsn_name, auth_string, options, error);
 
@@ -1125,7 +1122,6 @@ gda_connection_open_from_dsn (GdaDsnInfo *dsn,
 
   g_return_val_if_fail (dsn, NULL);
   g_return_val_if_fail (dsn->cnc_string, NULL);
-  g_return_val_if_fail (error == NULL || *error != NULL, NULL);
 
   cnc = gda_connection_new_from_dsn (dsn, auth_string, options, error);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]