[gnome-software] details page: Never show a 'missing' icon when AppStream does not provide an app icon

[Kalev Lember <klember src gnome org>]

commit 5cf0eed6f9cd67eeee4438ea5ea05a16203426cf
Author: Kalev Lember <klember redhat com>
Date:   Fri May 17 15:45:38 2019 +0200

    details page: Never show a 'missing' icon when AppStream does not provide an app icon
    
    Although this belies a metadata generation bug, fall back to showing the
    generic application icon rather than having a 'hole' in the UI where the icon
    would normally be.
    
    This matches commit c955d3a that fixed it for the app row class; this
    commit does the matching change for the details page.

 src/gs-details-page.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index b074af4d..2e31b0aa 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -1081,9 +1081,10 @@ gs_details_page_refresh_all (GsDetailsPage *self)
        pixbuf = gs_app_get_pixbuf (self->app);
        if (pixbuf != NULL) {
                gs_image_set_from_pixbuf (GTK_IMAGE (self->application_details_icon), pixbuf);
-               gtk_widget_set_visible (self->application_details_icon, TRUE);
        } else {
-               gtk_widget_set_visible (self->application_details_icon, FALSE);
+               gtk_image_set_from_icon_name (GTK_IMAGE (self->application_details_icon),
+                                             "application-x-executable",
+                                             GTK_ICON_SIZE_DIALOG);
        }
 
        tmp = gs_app_get_url (self->app, AS_URL_KIND_HOMEPAGE);