[gnome-shell] keyring: Use bind_property for message and description values
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] keyring: Use bind_property for message and description values
- Date: Wed, 15 May 2019 18:43:58 +0000 (UTC)
commit 51655be6a386d6782bcc453e2c904bdbd955fad4
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date: Thu Apr 25 14:29:45 2019 -0500
keyring: Use bind_property for message and description values
This code was commented out in commit 593b431 as it was causing a crash in gjs.
As per the [1] gjs fix, this can now be safely used again.
[1] https://gitlab.gnome.org/GNOME/gjs/merge_requests/289
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/510
js/ui/components/keyring.js | 12 ------------
1 file changed, 12 deletions(-)
---
diff --git a/js/ui/components/keyring.js b/js/ui/components/keyring.js
index 0d9f1e466..ab0793f54 100644
--- a/js/ui/components/keyring.js
+++ b/js/ui/components/keyring.js
@@ -23,20 +23,8 @@ var KeyringDialog = class extends ModalDialog.ModalDialog {
this._content = new Dialog.MessageDialogContent({ icon });
this.contentLayout.add(this._content);
- // FIXME: Why does this break now?
- /*
this.prompt.bind_property('message', this._content, 'title', GObject.BindingFlags.SYNC_CREATE);
this.prompt.bind_property('description', this._content, 'body', GObject.BindingFlags.SYNC_CREATE);
- */
- this.prompt.connect('notify::message', () => {
- this._content.title = this.prompt.message;
- });
- this._content.title = this.prompt.message;
-
- this.prompt.connect('notify::description', () => {
- this._content.body = this.prompt.description;
- });
- this._content.body = this.prompt.description;
this._workSpinner = null;
this._controlTable = null;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]