[gnome-keyring/wip/dueno/madvise] build: Remove configure check for MADV_DONTDUMP
- From: Daiki Ueno <dueno src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-keyring/wip/dueno/madvise] build: Remove configure check for MADV_DONTDUMP
- Date: Wed, 15 May 2019 04:44:11 +0000 (UTC)
commit 198d70364554dea570033aded74b339d1dc1d3a1
Author: Daiki Ueno <dueno src gnome org>
Date: Wed May 15 06:42:44 2019 +0200
build: Remove configure check for MADV_DONTDUMP
It can be checked in the source code instead.
configure.ac | 8 --------
egg/egg-secure-memory.c | 2 +-
2 files changed, 1 insertion(+), 9 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index de0c759b..4b836641 100644
--- a/configure.ac
+++ b/configure.ac
@@ -183,14 +183,6 @@ AC_CHECK_FUNCS(gettimeofday fsync)
AC_CHECK_FUNCS(mlock)
-# --------------------------------------------------------------------
-# Prevent memory from being included in core dumps
-#
-
-AC_CHECK_DEFINE([sys/mman.h],[MADV_DONTDUMP],
- AC_DEFINE([HAVE_MADV_DONTDUMP], [1],
- [Define if madvise knows about MADV_DONTDUMP]))
-
# --------------------------------------------------------------------
# socket()
#
diff --git a/egg/egg-secure-memory.c b/egg/egg-secure-memory.c
index 3dca8fb5..ed6fbcc8 100644
--- a/egg/egg-secure-memory.c
+++ b/egg/egg-secure-memory.c
@@ -885,7 +885,7 @@ sec_acquire_pages (size_t *sz,
DEBUG_ALLOC ("gkr-secure-memory: new block ", *sz);
-#if defined(HAVE_MADV_DONTDUMP)
+#if defined(MADV_DONTDUMP)
if (madvise (pages, *sz, MADV_DONTDUMP) < 0) {
if (show_warning && egg_secure_warnings) {
/*
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]