[epiphany] notebook: stop reordering tabs on startup



commit 2327bca65261af32cb30f031d153ab41b6687ce1
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Mon May 13 09:29:41 2019 -0500

    notebook: stop reordering tabs on startup
    
    This code that attempts (unsuccessfully, see #780) to ensure all pinned
    tabs are sorted on the left is also reversing the order of all
    non-pinned tabs on startup, which is not OK. Remove this for now. We'll
    need to try again.
    
    Fixes #777

 src/ephy-notebook.c | 15 ---------------
 1 file changed, 15 deletions(-)
---
diff --git a/src/ephy-notebook.c b/src/ephy-notebook.c
index ef8d56d9d..54e6c0513 100644
--- a/src/ephy-notebook.c
+++ b/src/ephy-notebook.c
@@ -484,19 +484,6 @@ get_last_pinned_tab_pos (GtkNotebook *notebook)
   return found;
 }
 
-static void
-page_reordered_cb (GtkNotebook *notebook,
-                   GtkWidget   *child,
-                   guint        page_num,
-                   gpointer     user_data)
-{
-  gint last_pinned_tab_pos = get_last_pinned_tab_pos (notebook);
-
-  /* Ensure that pinned tabs will always stay at the beginning of tab bar */
-  if (last_pinned_tab_pos != -1 && page_num <= (guint)last_pinned_tab_pos)
-    gtk_notebook_reorder_child (notebook, child, last_pinned_tab_pos);
-}
-
 static void
 ephy_notebook_init (EphyNotebook *notebook)
 {
@@ -516,8 +503,6 @@ ephy_notebook_init (EphyNotebook *notebook)
   g_signal_connect_after (notebook, "switch-page",
                           G_CALLBACK (ephy_notebook_switch_page_cb),
                           NULL);
-  g_signal_connect (notebook, "page-reordered",
-                    (GCallback)page_reordered_cb, NULL);
 
   /* Set up drag-and-drop target */
   g_signal_connect (notebook, "drag-data-received",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]