[gnome-boxes/express-install-password-setup] unattended-setup-box: Don't steal input focus from username entry



commit 78123c25280596462fa87cd8a12a0bb3522d45be
Author: Felipe Borges <felipeborges gnome org>
Date:   Mon May 13 12:46:28 2019 +0200

    unattended-setup-box: Don't steal input focus from username entry
    
    When users are typing in the Username entry (in the Wizard), we
    run checks that verify whether all the info required to perform an
    express installation has already been inputed.
    
    Commit 9746c63 introduced a bug in which the password entry was
    grabing focus (and consequently stealing it from username entry)
    for the period when the password entry is empty.
    
    Fixes #347

 data/ui/unattended-setup-box.ui | 3 +++
 src/unattended-setup-box.vala   | 5 -----
 2 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/data/ui/unattended-setup-box.ui b/data/ui/unattended-setup-box.ui
index fab22ebf..85a6295b 100644
--- a/data/ui/unattended-setup-box.ui
+++ b/data/ui/unattended-setup-box.ui
@@ -182,6 +182,9 @@
                     <property name="use-underline">True</property>
                     <property name="valign">baseline</property>
                     <signal name="clicked" handler="on_password_button_clicked"/>
+                    <style>
+                      <class name="suggested-action"/>
+                    </style>
                   </object>
                 </child>
                 <child>
diff --git a/src/unattended-setup-box.vala b/src/unattended-setup-box.vala
index a6cf96b5..a2aa1152 100644
--- a/src/unattended-setup-box.vala
+++ b/src/unattended-setup-box.vala
@@ -79,11 +79,6 @@
             if (password != "")
                 return false;
 
-            if (_needs_password) {
-                password_notebook.next_page ();
-                password_entry.grab_focus ();
-            }
-
             return _needs_password;
         }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]