[balsa] balsa-message: Connect to "search-changed" signal



commit fb795d4824e62d827f9637eab4ba77c77b4be1ed
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Fri May 10 23:00:09 2019 -0400

    balsa-message: Connect to "search-changed" signal
    
    Connect to GtkSearchEntry's "search-changed" signal instead of
    GtkEditable's "changed" signal; it provides a 150 msec delay: "To make
    filtering appear more reactive, it is a good idea to not react to every
    change in the entry text immediately, but only after a short delay. To
    support this, GtkSearchEntry emits the “search-changed” signal which
    can be used instead of the “changed” signal."
    
    * src/balsa-message.c (bm_find_bar_new): connect to
      GtkSearchEntry's "search-changed" signal instead of GtkEditable's
      "changed" signal

 ChangeLog           | 12 ++++++++++++
 src/balsa-message.c |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
---
diff --git a/ChangeLog b/ChangeLog
index a44fa3e0e..0cddb8df2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2019-05-10  Peter Bloomfield  <pbloomfield bellsouth net>
+
+       * src/balsa-message.c (bm_find_bar_new): connect to
+       GtkSearchEntry's "search-changed" signal instead of GtkEditable's
+       "changed" signal; it provides a 150 msec delay:
+       "To make filtering appear more reactive, it is a good idea
+       to not react to every change in the entry text immediately,
+       but only after a short delay. To support this, GtkSearchEntry
+       emits the “search-changed” signal which can be used instead
+       of the “changed” signal."
+
+
 2019-05-10  Peter Bloomfield  <pbloomfield bellsouth net>
 
        main-window: Clear the view filter when the search text is
diff --git a/src/balsa-message.c b/src/balsa-message.c
index e35d74df6..8100124cd 100644
--- a/src/balsa-message.c
+++ b/src/balsa-message.c
@@ -614,7 +614,7 @@ bm_find_bar_new(BalsaMessage * bm)
     gtk_box_pack_start(GTK_BOX(hbox), gtk_label_new(_("Find:")),
                        FALSE, FALSE, 0);
     bm->find_entry = gtk_search_entry_new();
-    g_signal_connect(bm->find_entry, "changed",
+    g_signal_connect(bm->find_entry, "search-changed",
                      G_CALLBACK(bm_find_entry_changed_cb), bm);
     gtk_box_pack_start(GTK_BOX(hbox), bm->find_entry, FALSE, FALSE, 0);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]