[orca] Treat offscreen links as if they are on a line by themselves



commit fc9d7dda8330e376d7787fbdcb8acd4572ec580b
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Fri May 10 18:23:47 2019 +0200

    Treat offscreen links as if they are on a line by themselves
    
    Offscreen content can lead to bogus bounding boxes being reported and
    our combining things that we shouldn't be combining. Since we cannot
    trust the bounding boxes, it is safer to isolate the associated content.

 src/orca/scripts/web/script_utilities.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 01f3ca36a..b00118f66 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -1481,7 +1481,7 @@ class Utilities(script_utilities.Utilities):
 
         boundary = pyatspi.TEXT_BOUNDARY_LINE_START
         objects = self._getContentsForObj(obj, offset, boundary)
-        if not layoutMode:
+        if not layoutMode or self.isOffScreenLink(obj):
             if useCache:
                 self._currentLineContents = objects
             return objects


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]