[epiphany/gnome-3-32] location-entry: destroy bookmark popover in dispose
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/gnome-3-32] location-entry: destroy bookmark popover in dispose
- Date: Thu, 9 May 2019 21:28:39 +0000 (UTC)
commit dfdc5bda198f8789d9b64b3efe52a002b7c5849c
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Tue May 7 22:31:19 2019 +0000
location-entry: destroy bookmark popover in dispose
The EphyAddBookmarkPopover can currently outlive the EphyLocationEntry.
That's bad!
Speculative fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1707455
(cherry picked from commit bae5b1d3fb03528f929857fe3df32ccad5f7cb30)
lib/widgets/ephy-location-entry.c | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/lib/widgets/ephy-location-entry.c b/lib/widgets/ephy-location-entry.c
index 0beb4b507..5faa882c7 100644
--- a/lib/widgets/ephy-location-entry.c
+++ b/lib/widgets/ephy-location-entry.c
@@ -394,6 +394,8 @@ ephy_location_entry_dispose (GObject *object)
g_clear_object (&entry->css_provider);
+ gtk_widget_destroy (GTK_WIDGET (entry->add_bookmark_popover));
+
G_OBJECT_CLASS (ephy_location_entry_parent_class)->dispose (object);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]