[gimp/gimp-2-10] Issue #3353 - Gimp 2.10.10 freezes while changing Background color ...
- From: Ell <ell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp/gimp-2-10] Issue #3353 - Gimp 2.10.10 freezes while changing Background color ...
- Date: Wed, 8 May 2019 07:46:14 +0000 (UTC)
commit 2d91f1ca0239ec3b384eaf1e1f4495de49a42519
Author: Ell <ell_se yahoo com>
Date: Wed May 8 03:32:39 2019 -0400
Issue #3353 - Gimp 2.10.10 freezes while changing Background color ...
... in LCh colorspace
In gimptoolbox-color-area, when setting the context's background
color in response to a color-dialog change, block the right signal
handler, to avoid re-setting the color dialog's color, which would
cause the GtkAdjustment's "value-changed" signal (assuming it was
the source of the change) to be restarted if the new value doesn't
match the current one exactly, which can happen due to conversion
errors.
(cherry picked from commit c7a29e5f98ecb833bf2d87a1df9963a633c6fbe7)
app/widgets/gimptoolbox-color-area.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/app/widgets/gimptoolbox-color-area.c b/app/widgets/gimptoolbox-color-area.c
index 1a7ef6efb9..46a5ecdba5 100644
--- a/app/widgets/gimptoolbox-color-area.c
+++ b/app/widgets/gimptoolbox-color-area.c
@@ -179,13 +179,13 @@ color_area_dialog_update (GimpColorDialog *dialog,
else
{
g_signal_handlers_block_by_func (context,
- color_area_foreground_changed,
+ color_area_background_changed,
dialog);
gimp_context_set_background (context, color);
g_signal_handlers_unblock_by_func (context,
- color_area_foreground_changed,
+ color_area_background_changed,
dialog);
}
break;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]