[epiphany/mcatanzaro/add-bookmark-popover-crash] location-entry: destroy bookmark popover in dispose
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/add-bookmark-popover-crash] location-entry: destroy bookmark popover in dispose
- Date: Tue, 7 May 2019 22:33:06 +0000 (UTC)
commit 8eb951dc94ec06ae688fbe35f4ab35ec3142dd2f
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Tue May 7 17:31:19 2019 -0500
location-entry: destroy bookmark popover in dispose
The EphyAddBookmarkPopover can currently outlive the EphyLocationEntry.
That's bad!
Speculative fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1707455
lib/widgets/ephy-location-entry.c | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/lib/widgets/ephy-location-entry.c b/lib/widgets/ephy-location-entry.c
index 93f5552c1..7edace4b3 100644
--- a/lib/widgets/ephy-location-entry.c
+++ b/lib/widgets/ephy-location-entry.c
@@ -377,6 +377,8 @@ ephy_location_entry_dispose (GObject *object)
g_clear_object (&entry->css_provider);
+ gtk_widget_destroy (entry->add_bookmark_popover);
+
G_OBJECT_CLASS (ephy_location_entry_parent_class)->dispose (object);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]