[gnome-shell] Revert "st: Reload icon on style changes only if necessary"

[Florian Müllner <fmuellner src gnome org>]

commit 598407b14a82bcaed3fce54f9aa97b49e0c1c511
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri May 3 21:24:43 2019 +0000

    Revert "st: Reload icon on style changes only if necessary"
    
    The size isn't the only relevant style change, we also need to pick
    up icon-colors, icon-style and icon-shadow.
    
    This reverts commit 94995e9c1e1ffc3eb44c06d23a30a2ac8cd2455d.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/529

 src/st/st-icon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/st/st-icon.c b/src/st/st-icon.c
index 8b7015281..04d2d1d3c 100644
--- a/src/st/st-icon.c
+++ b/src/st/st-icon.c
@@ -206,8 +206,8 @@ st_icon_style_changed (StWidget *widget)
     }
 
   priv->theme_icon_size = (int)(0.5 + st_theme_node_get_length (theme_node, "icon-size"));
-  if (st_icon_update_icon_size (self))
-    st_icon_update (self);
+  st_icon_update_icon_size (self);
+  st_icon_update (self);
 }
 
 static void