[gnome-control-center/wip/hadess/unknown-device-batteries] power: Don't treat all batteries as laptop batteries
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center/wip/hadess/unknown-device-batteries] power: Don't treat all batteries as laptop batteries
- Date: Tue, 7 May 2019 10:57:57 +0000 (UTC)
commit dff4d1f323e80b7e6c945fdc9aed6b2b31571978
Author: Bastien Nocera <hadess hadess net>
Date: Tue May 7 12:53:23 2019 +0200
power: Don't treat all batteries as laptop batteries
They might be device batteries where the device type is not known or
catalogued.
panels/power/cc-power-panel.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
---
diff --git a/panels/power/cc-power-panel.c b/panels/power/cc-power-panel.c
index 477427de8..d24b68d54 100644
--- a/panels/power/cc-power-panel.c
+++ b/panels/power/cc-power-panel.c
@@ -872,8 +872,13 @@ up_client_changed (UpClient *client,
for (i = 0; self->devices != NULL && i < self->devices->len; i++)
{
UpDevice *device = (UpDevice*) g_ptr_array_index (self->devices, i);
- g_object_get (device, "kind", &kind, NULL);
- if (kind == UP_DEVICE_KIND_BATTERY)
+ gboolean is_power_supply = FALSE;
+ g_object_get (device,
+ "kind", &kind,
+ "power-supply", &is_power_supply,
+ NULL);
+ if (kind == UP_DEVICE_KIND_BATTERY &&
+ is_power_supply)
{
n_batteries++;
if (is_extra_battery == FALSE)
@@ -897,7 +902,11 @@ up_client_changed (UpClient *client,
for (i = 0; self->devices != NULL && i < self->devices->len; i++)
{
UpDevice *device = (UpDevice*) g_ptr_array_index (self->devices, i);
- g_object_get (device, "kind", &kind, NULL);
+ gboolean is_power_supply = FALSE;
+ g_object_get (device,
+ "kind", &kind,
+ "power-supply", &is_power_supply,
+ NULL);
if (kind == UP_DEVICE_KIND_LINE_POWER)
{
/* do nothing */
@@ -906,11 +915,11 @@ up_client_changed (UpClient *client,
{
set_primary (self, device);
}
- else if (kind == UP_DEVICE_KIND_BATTERY && !on_ups && n_batteries == 1)
+ else if (kind == UP_DEVICE_KIND_BATTERY && is_power_supply && !on_ups && n_batteries == 1)
{
set_primary (self, device);
}
- else if (kind == UP_DEVICE_KIND_BATTERY)
+ else if (kind == UP_DEVICE_KIND_BATTERY && is_power_supply)
{
add_battery (self, device);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]