[gnome-music/wip/jfelder/player-simplify-eos] player: Simplify _on_eos method



commit 84e97991024546b27326ccf40ed1cc47b5080abe
Author: Jean Felder <jfelder src gnome org>
Date:   Tue Apr 30 16:06:13 2019 +0200

    player: Simplify _on_eos method
    
    on_glib_idle function does exactly the same thing as the next
    method. So, it can be directly replaced by a call to the next
    method. The idle_add call can also be replaced as it serves no
    purpose.

 gnomemusic/player.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/gnomemusic/player.py b/gnomemusic/player.py
index 07f362e9..dcdfd5b5 100644
--- a/gnomemusic/player.py
+++ b/gnomemusic/player.py
@@ -34,7 +34,7 @@ gi.require_version('Grl', '0.3')
 gi.require_version('Gst', '1.0')
 gi.require_version('GstAudio', '1.0')
 gi.require_version('GstPbutils', '1.0')
-from gi.repository import GLib, GObject, Grl, GstPbutils
+from gi.repository import GObject, Grl, GstPbutils
 
 from gnomemusic import log
 from gnomemusic.gstplayer import GstPlayer, Playback
@@ -628,12 +628,8 @@ class Player(GObject.GObject):
 
     @log
     def _on_eos(self, klass):
-        def on_glib_idle():
-            self._playlist.next()
-            self.play()
-
         if self.props.has_next:
-            GLib.idle_add(on_glib_idle)
+            self.next()
         else:
             self.stop()
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]