[vala/0.44] vala: Report error for unsupported operator instead of	assertion
- From: Rico Tzschichholz <ricotz src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [vala/0.44] vala: Report error for unsupported operator instead of	assertion
 
- Date: Thu, 28 Mar 2019 09:55:28 +0000 (UTC)
 
commit f374cd16fb7da6e65eb1d368b1a8ef0824095b5a
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Wed Mar 27 09:55:31 2019 +0100
    vala: Report error for unsupported operator instead of assertion
 vala/valaassignment.vala       | 5 ++++-
 vala/valabinaryexpression.vala | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index 0b6fbc9ad..91bcee308 100644
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -246,7 +246,10 @@ public class Vala.Assignment : Expression {
                        case AssignmentOperator.PERCENT: bop = BinaryOperator.MOD; break;
                        case AssignmentOperator.SHIFT_LEFT: bop = BinaryOperator.SHIFT_LEFT; break;
                        case AssignmentOperator.SHIFT_RIGHT: bop = BinaryOperator.SHIFT_RIGHT; break;
-                       default: assert_not_reached ();
+                       default:
+                               error = true;
+                               Report.error (source_reference, "internal error: unsupported assignment 
operator");
+                               return false;
                        }
 
                        var bin = new BinaryExpression (bop, old_value, right, source_reference);
diff --git a/vala/valabinaryexpression.vala b/vala/valabinaryexpression.vala
index eb1ea1b8c..f21aa42c0 100644
--- a/vala/valabinaryexpression.vala
+++ b/vala/valabinaryexpression.vala
@@ -545,7 +545,9 @@ public class Vala.BinaryExpression : Expression {
                        value_type = context.analyzer.bool_type;
 
                } else {
-                       assert_not_reached ();
+                       error = true;
+                       Report.error (source_reference, "internal error: unsupported binary operator");
+                       return false;
                }
 
                value_type.check (context);
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]