[gtk/wip/otte/reftests: 1/5] reftests: Actually build a module



commit 77131e62775fcd0b1f608a3cdc0d63cf21ce41a8
Author: Benjamin Otte <otte redhat com>
Date:   Wed Mar 27 04:52:59 2019 +0100

    reftests: Actually build a module
    
    Reftests are expecting a module called libreftest.so, so don't build a
    static libgtkreftest.a but what they expect.

 testsuite/reftests/gtk-reftest.h |  4 ++--
 testsuite/reftests/meson.build   | 24 +++++++++++++-----------
 2 files changed, 15 insertions(+), 13 deletions(-)
---
diff --git a/testsuite/reftests/gtk-reftest.h b/testsuite/reftests/gtk-reftest.h
index e30c78f0ea..e4da797626 100644
--- a/testsuite/reftests/gtk-reftest.h
+++ b/testsuite/reftests/gtk-reftest.h
@@ -21,8 +21,8 @@
 G_BEGIN_DECLS
 
 /* reftest-snapshot.c */
-void reftest_inhibit_snapshot   (void);
-void reftest_uninhibit_snapshot (void);
+extern void reftest_inhibit_snapshot   (void);
+extern void reftest_uninhibit_snapshot (void);
 
 G_END_DECLS
 
diff --git a/testsuite/reftests/meson.build b/testsuite/reftests/meson.build
index 7b758ca550..de8176b1c4 100644
--- a/testsuite/reftests/meson.build
+++ b/testsuite/reftests/meson.build
@@ -3,15 +3,17 @@ libgtkreftestprivate = static_library('gtkreftestprivate',
   'reftest-compare.c', 'reftest-module.c', 'reftest-snapshot.c',
   dependencies : libgtk_dep)
 
-libreftest = static_library('gtkreftest',
-  'expand-expander.c',
-  'frame-inhibitor.c',
-  'letter-spacing.c',
-  'set-default-direction.c',
-  'statusbar-remove-all.c',
-  'textview-border-windows.c',
-  'textview-tags.c',
-  'animation-direction.c',
+libreftest = shared_module('reftest',
+  [ 'expand-expander.c',
+    'frame-inhibitor.c',
+    'letter-spacing.c',
+    'set-default-direction.c',
+    'statusbar-remove-all.c',
+    'textview-border-windows.c',
+    'textview-tags.c',
+    'animation-direction.c',
+  ],
+  link_with: libgtkreftestprivate,
   dependencies : libgtk_dep)
 
 tcdata = configuration_data()
@@ -428,13 +430,13 @@ foreach testname : testdata
        args: [ '--tap', '-k', '--verbose', join_paths(meson.current_source_dir(), testname) ],
        env: [ 'GIO_USE_VOLUME_MONITOR=unix',
               'GSETTINGS_BACKEND=memory',
-              'GSETTINGS_SCHEMA_DIR=@@'.format(gtk_schema_build_dir),
+              'GSETTINGS_SCHEMA_DIR=@0@'.format(gtk_schema_build_dir),
               'GTK_CSD=1',
               'G_ENABLE_DIAGNOSTIC=0',
               'G_TEST_SRCDIR=@0@'.format(meson.current_source_dir()),
               'G_TEST_BUILDDIR=@0@'.format(meson.current_build_dir()),
               'GSK_RENDERER=opengl',
-              'REFTEST_MODULE_DIR=@@'.format(meson.current_build_dir()),
+              'REFTEST_MODULE_DIR=@0@'.format(meson.current_build_dir()),
             ],
        suite: 'reftest')
 endforeach


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]