GNOME.org
 

[gtk/gtk-3-24] gtk: Remove all gtk_widget_set_redraw_on_allocate() calls

commit bbb70857bee1211130544edeeaae91a2be35c610
Author: Benjamin Otte <otte redhat com>
Date:   Wed Mar 27 00:01:08 2019 +0100

    gtk: Remove all gtk_widget_set_redraw_on_allocate() calls
    
    They're either wrong (when using FALSE because the widgets don't account
    for changes to the CSS) or unnecessary (when using TRUE because it's the
    default).
    
    Fixes !1777

 gtk/deprecated/gtkalignment.c | 1 -
 gtk/deprecated/gtktable.c     | 1 -
 gtk/gtkactionbar.c            | 2 --
 gtk/gtkbox.c                  | 1 -
 gtk/gtkflowbox.c              | 2 --
 gtk/gtkgrid.c                 | 1 -
 gtk/gtkheaderbar.c            | 1 -
 gtk/gtkinfobar.c              | 2 --
 gtk/gtklistbox.c              | 2 --
 gtk/gtkpaned.c                | 5 -----
 gtk/gtkpathbar.c              | 1 -
 gtk/gtkrevealer.c             | 1 -
 gtk/gtkstatusbar.c            | 1 -
 gtk/gtktextview.c             | 3 ---
 gtk/gtktoolitemgroup.c        | 2 --
 gtk/gtktreeview.c             | 1 -
 gtk/gtkviewport.c             | 1 -
 17 files changed, 28 deletions(-)
---
diff --git a/gtk/deprecated/gtkalignment.c b/gtk/deprecated/gtkalignment.c
index eaf7f2bd4c..076633b341 100644
--- a/gtk/deprecated/gtkalignment.c
+++ b/gtk/deprecated/gtkalignment.c
@@ -297,7 +297,6 @@ gtk_alignment_init (GtkAlignment *alignment)
   priv = alignment->priv;
 
   gtk_widget_set_has_window (GTK_WIDGET (alignment), FALSE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (alignment), FALSE);
 
   priv->xalign = 0.5;
   priv->yalign = 0.5;
diff --git a/gtk/deprecated/gtktable.c b/gtk/deprecated/gtktable.c
index b51f869327..463eaebff9 100644
--- a/gtk/deprecated/gtktable.c
+++ b/gtk/deprecated/gtktable.c
@@ -507,7 +507,6 @@ gtk_table_init (GtkTable *table)
   priv = table->priv;
 
   gtk_widget_set_has_window (GTK_WIDGET (table), FALSE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (table), FALSE);
 
   priv->children = NULL;
   priv->rows = NULL;
diff --git a/gtk/gtkactionbar.c b/gtk/gtkactionbar.c
index a4bb1130a4..64162c1dfe 100644
--- a/gtk/gtkactionbar.c
+++ b/gtk/gtkactionbar.c
@@ -362,8 +362,6 @@ gtk_action_bar_init (GtkActionBar *action_bar)
   GtkActionBarPrivate *priv = gtk_action_bar_get_instance_private (action_bar);
   GtkCssNode *widget_node;
 
-  gtk_widget_set_redraw_on_allocate (widget, TRUE);
-
   gtk_widget_init_template (GTK_WIDGET (action_bar));
 
   gtk_revealer_set_transition_type (GTK_REVEALER (priv->revealer), GTK_REVEALER_TRANSITION_TYPE_SLIDE_UP);
diff --git a/gtk/gtkbox.c b/gtk/gtkbox.c
index 44aa112d9c..3c4534a092 100644
--- a/gtk/gtkbox.c
+++ b/gtk/gtkbox.c
@@ -2099,7 +2099,6 @@ gtk_box_init (GtkBox *box)
   private = box->priv;
 
   gtk_widget_set_has_window (GTK_WIDGET (box), FALSE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (box), FALSE);
 
   private->orientation = GTK_ORIENTATION_HORIZONTAL;
   private->children = NULL;
diff --git a/gtk/gtkflowbox.c b/gtk/gtkflowbox.c
index d8c469b7fa..0a02376bb9 100644
--- a/gtk/gtkflowbox.c
+++ b/gtk/gtkflowbox.c
@@ -640,7 +640,6 @@ static void
 gtk_flow_box_child_init (GtkFlowBoxChild *child)
 {
   gtk_widget_set_can_focus (GTK_WIDGET (child), TRUE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (child), TRUE);
 
   CHILD_PRIV (child)->gadget = gtk_css_custom_gadget_new_for_node (gtk_widget_get_css_node (GTK_WIDGET 
(child)),
                                                      GTK_WIDGET (child),
@@ -4106,7 +4105,6 @@ gtk_flow_box_init (GtkFlowBox *box)
   GtkCssNode *widget_node;
 
   gtk_widget_set_has_window (GTK_WIDGET (box), TRUE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (box), TRUE);
 
   priv->orientation = GTK_ORIENTATION_HORIZONTAL;
   priv->selection_mode = GTK_SELECTION_SINGLE;
diff --git a/gtk/gtkgrid.c b/gtk/gtkgrid.c
index 2b0176aee3..40d78f2275 100644
--- a/gtk/gtkgrid.c
+++ b/gtk/gtkgrid.c
@@ -1831,7 +1831,6 @@ gtk_grid_init (GtkGrid *grid)
   priv = grid->priv;
 
   gtk_widget_set_has_window (GTK_WIDGET (grid), FALSE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (grid), FALSE);
 
   priv->children = NULL;
   priv->orientation = GTK_ORIENTATION_HORIZONTAL;
diff --git a/gtk/gtkheaderbar.c b/gtk/gtkheaderbar.c
index a731cca328..39e81b4079 100644
--- a/gtk/gtkheaderbar.c
+++ b/gtk/gtkheaderbar.c
@@ -2131,7 +2131,6 @@ gtk_header_bar_init (GtkHeaderBar *bar)
   priv = gtk_header_bar_get_instance_private (bar);
 
   gtk_widget_set_has_window (GTK_WIDGET (bar), FALSE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (bar), FALSE);
 
   priv->title = NULL;
   priv->subtitle = NULL;
diff --git a/gtk/gtkinfobar.c b/gtk/gtkinfobar.c
index 477fc87dcd..9d156afd4a 100644
--- a/gtk/gtkinfobar.c
+++ b/gtk/gtkinfobar.c
@@ -506,8 +506,6 @@ gtk_info_bar_init (GtkInfoBar *info_bar)
 
   priv = info_bar->priv = gtk_info_bar_get_instance_private (info_bar);
 
-  gtk_widget_set_redraw_on_allocate (widget, TRUE);
-
   /* message-type is a CONSTRUCT property, so we init to a value
    * different from its default to trigger its property setter
    * during construction */
diff --git a/gtk/gtklistbox.c b/gtk/gtklistbox.c
index a1213d2928..b77a27e4d9 100644
--- a/gtk/gtklistbox.c
+++ b/gtk/gtklistbox.c
@@ -665,7 +665,6 @@ gtk_list_box_init (GtkListBox *box)
   GtkCssNode *widget_node;
 
   gtk_widget_set_has_window (widget, TRUE);
-  gtk_widget_set_redraw_on_allocate (widget, TRUE);
   priv->selection_mode = GTK_SELECTION_SINGLE;
   priv->activate_single_click = TRUE;
 
@@ -3934,7 +3933,6 @@ static void
 gtk_list_box_row_init (GtkListBoxRow *row)
 {
   gtk_widget_set_can_focus (GTK_WIDGET (row), TRUE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (row), TRUE);
 
   ROW_PRIV (row)->activatable = TRUE;
   ROW_PRIV (row)->selectable = TRUE;
diff --git a/gtk/gtkpaned.c b/gtk/gtkpaned.c
index 7610ff2e1d..7e215228a8 100644
--- a/gtk/gtkpaned.c
+++ b/gtk/gtkpaned.c
@@ -1896,11 +1896,6 @@ gtk_paned_init (GtkPaned *paned)
   gtk_widget_set_has_window (GTK_WIDGET (paned), FALSE);
   gtk_widget_set_can_focus (GTK_WIDGET (paned), TRUE);
 
-  /* We only need to redraw when the handle position moves, which is
-   * independent of the overall allocation of the GtkPaned
-   */
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (paned), FALSE);
-
   paned->priv = gtk_paned_get_instance_private (paned);
   priv = paned->priv;
 
diff --git a/gtk/gtkpathbar.c b/gtk/gtkpathbar.c
index 805610629e..99d5282888 100644
--- a/gtk/gtkpathbar.c
+++ b/gtk/gtkpathbar.c
@@ -268,7 +268,6 @@ gtk_path_bar_init (GtkPathBar *path_bar)
                            G_CALLBACK (gtk_path_bar_scroll_down), path_bar);
 
   gtk_widget_set_has_window (GTK_WIDGET (path_bar), FALSE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (path_bar), FALSE);
 
   context = gtk_widget_get_style_context (GTK_WIDGET (path_bar));
   gtk_style_context_add_class (context, "path-bar");
diff --git a/gtk/gtkrevealer.c b/gtk/gtkrevealer.c
index 7560293114..ca01283f06 100644
--- a/gtk/gtkrevealer.c
+++ b/gtk/gtkrevealer.c
@@ -144,7 +144,6 @@ gtk_revealer_init (GtkRevealer *revealer)
   priv->target_pos = 0.0;
 
   gtk_widget_set_has_window ((GtkWidget*) revealer, TRUE);
-  gtk_widget_set_redraw_on_allocate ((GtkWidget*) revealer, FALSE);
 }
 
 static void
diff --git a/gtk/gtkstatusbar.c b/gtk/gtkstatusbar.c
index 5eeb039e57..8d34f6476d 100644
--- a/gtk/gtkstatusbar.c
+++ b/gtk/gtkstatusbar.c
@@ -205,7 +205,6 @@ gtk_statusbar_init (GtkStatusbar *statusbar)
   priv->keys = NULL;
 
   gtk_widget_init_template (GTK_WIDGET (statusbar));
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (statusbar), TRUE);
 }
 
 /**
diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c
index 9aab0af7ba..40ba9043c4 100644
--- a/gtk/gtktextview.c
+++ b/gtk/gtktextview.c
@@ -1762,9 +1762,6 @@ gtk_text_view_init (GtkTextView *text_view)
   priv->text_window = text_window_new (GTK_TEXT_WINDOW_TEXT,
                                        widget, 200, 200);
 
-  /* We handle all our own redrawing */
-  gtk_widget_set_redraw_on_allocate (widget, FALSE);
-
   priv->multipress_gesture = gtk_gesture_multi_press_new (widget);
   gtk_gesture_single_set_button (GTK_GESTURE_SINGLE (priv->multipress_gesture), 0);
   g_signal_connect (priv->multipress_gesture, "pressed",
diff --git a/gtk/gtktoolitemgroup.c b/gtk/gtktoolitemgroup.c
index c4dbbcbbe5..ad4bf88cca 100644
--- a/gtk/gtktoolitemgroup.c
+++ b/gtk/gtktoolitemgroup.c
@@ -402,8 +402,6 @@ gtk_tool_item_group_init (GtkToolItemGroup *group)
   GtkToolItemGroupPrivate* priv;
   GtkCssNode *widget_node;
 
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (group), FALSE);
-
   group->priv = priv = gtk_tool_item_group_get_instance_private (group);
 
   priv->children = NULL;
diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index a2f1b3b9e3..cb7b8f7c47 100644
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -1786,7 +1786,6 @@ gtk_tree_view_init (GtkTreeView *tree_view)
   priv = tree_view->priv = gtk_tree_view_get_instance_private (tree_view);
 
   gtk_widget_set_can_focus (GTK_WIDGET (tree_view), TRUE);
-  gtk_widget_set_redraw_on_allocate (GTK_WIDGET (tree_view), FALSE);
 
   priv->show_expanders = TRUE;
   priv->draw_keyfocus = TRUE;
diff --git a/gtk/gtkviewport.c b/gtk/gtkviewport.c
index a5487ffc70..601d5a1c86 100644
--- a/gtk/gtkviewport.c
+++ b/gtk/gtkviewport.c
@@ -501,7 +501,6 @@ gtk_viewport_init (GtkViewport *viewport)
   widget = GTK_WIDGET (viewport);
 
   gtk_widget_set_has_window (widget, TRUE);
-  gtk_widget_set_redraw_on_allocate (widget, FALSE);
 
   priv->shadow_type = GTK_SHADOW_IN;
   priv->view_window = NULL;
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]