[gnome-builder/gnome-builder-3-32] src: moan if $HOME is a symlink

[Christian Hergert <chergert src gnome org>]

commit 1e10b35bc9573c22951c5fc05868b3f0e7cbd2b6
Author: Christian Hergert <chergert redhat com>
Date:   Tue Mar 26 12:54:03 2019 -0700

    src: moan if $HOME is a symlink
    
    Old Silverblue installs do this, and it causes a number of issues. We can
    at least warn about it up front.

 src/main.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
---
diff --git a/src/main.c b/src/main.c
index 658ac55e1..f3d18a505 100644
--- a/src/main.c
+++ b/src/main.c
@@ -114,6 +114,19 @@ main (gint   argc,
   /* Extract options like -vvvv */
   early_params_check (&argc, &argv, &standalone, &type, &plugin, &dbus_address);
 
+  /* Make sure $HOME is not a symlink, as that can cause issues with
+   * various subsystems. Just warn super loud so that users find it
+   * when trying to debug issues.
+   *
+   * Silverblue did this, but has since stopped (and some users will
+   * lag behind until their systems are fixed).
+   *
+   * https://gitlab.gnome.org/GNOME/gnome-builder/issues/859
+   */
+  if (g_file_test (g_get_home_dir (), G_FILE_TEST_IS_SYMLINK))
+    g_critical ("User home directory uses a symlink. "
+                "This is not supported and may result in unforseen issues.");
+
   /* Log what desktop is being used to simplify tracking down
    * quirks in the future.
    */