[balsa] mailbox-conf.c: Fix maildir config crash



commit ad69f05d1f11db7a1be4c37608aa17db02bcde58
Author: Albrecht Dreß <albrecht dress arcor de>
Date:   Thu Mar 21 20:11:03 2019 -0400

    mailbox-conf.c: Fix maildir config crash
    
    I noticed that /sometimes/ closing the config dialogue of an
    existing maildir mailbox segfaults.  It appears that this
    is caused by an uninitialised file chooser (I modified the
    particular code snippet a while ago…).
    
    * src/mailbox-conf.c (create_local_mailbox_dialog):  Fix maildir
    config crash

 ChangeLog          | 12 ++++++++++++
 src/mailbox-conf.c |  6 ++----
 2 files changed, 14 insertions(+), 4 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index a8dfb335b..ca86d795f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2019-03-21  Albrecht Dreß  <albrecht dress arcor de>
+
+       I noticed that /sometimes/ closing the config dialogue of an
+       existing maildir mailbox segfaults.  It appears that this
+       is caused by an uninitialised file chooser (I modified the
+       particular code snippet a while ago…).  I am quite sure I
+       tested the changes, including maildir (the format I typically
+       use), no idea why this slipped through, sorry!
+
+       * src/mailbox-conf.c (create_local_mailbox_dialog):  Fix maildir
+       config crash
+
 2019-03-12  Albrecht Dreß  <albrecht dress arcor de>
 
        Broken mailbox view after moving IMAP folder sideways
diff --git a/src/mailbox-conf.c b/src/mailbox-conf.c
index e491833ec..79cba5898 100644
--- a/src/mailbox-conf.c
+++ b/src/mailbox-conf.c
@@ -735,11 +735,9 @@ create_local_mailbox_dialog(MailboxConfWindow *mcw)
                const gchar *path = libbalsa_mailbox_local_get_path(LIBBALSA_MAILBOX_LOCAL(mcw->mailbox));
                gchar *basename = g_path_get_basename(path);
 
-               //gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), path);
-               //gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog), basename);
-               gtk_file_chooser_set_uri(GTK_FILE_CHOOSER(dialog), mcw->mailbox->url);
+               gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), path);
+               gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog), basename);
                g_free(basename);
-               // FIXME - not optimal
     } else {
         gtk_file_chooser_set_current_folder(GTK_FILE_CHOOSER(dialog), balsa_app.local_mail_directory);
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]