[gupnp] service-proxy: Fix deadlock when cancelling action



commit d208562657f62b34759896ca9e974bd582d1f963
Author: Jens Georg <mail jensge org>
Date:   Mon Mar 18 22:25:51 2019 +0100

    service-proxy: Fix deadlock when cancelling action
    
    RTFM. g_cancellable_disconnect literally says that.

 libgupnp/gupnp-service-proxy.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/libgupnp/gupnp-service-proxy.c b/libgupnp/gupnp-service-proxy.c
index 6ac83d7..78c3354 100644
--- a/libgupnp/gupnp-service-proxy.c
+++ b/libgupnp/gupnp-service-proxy.c
@@ -621,8 +621,6 @@ on_action_cancelled (GCancellable *cancellable, gpointer user_data)
                 soup_session_cancel_message (session,
                                              action->msg,
                                              SOUP_STATUS_CANCELLED);
-                g_cancellable_disconnect (action->cancellable,
-                                          action->cancellable_connection_id);
                 action->cancellable_connection_id = 0;
         }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]