[gnome-control-center/benzea/display-fix-join-config-creation: 2/2] display: Enable all monitors when switching to join config

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit 3069e6aca45330bf9740e602d5739170869fbd51
Author: Benjamin Berg <bberg redhat com>
Date:   Mon Mar 18 11:49:22 2019 +0100

    display: Enable all monitors when switching to join config
    
    The new code had a bug in that it only ever enabled the first monitor
    rather than all usable ones. Fix this by removing the erroronuous break.
    Also clarify the comment a bit that the current solution is not really
    ideal as it may result in invalid configurations (i.e. we enable more
    outputs than are possible with the number of available CRTCs).
    
    Fixes #418

 panels/display/cc-display-panel.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/panels/display/cc-display-panel.c b/panels/display/cc-display-panel.c
index 85ea4ce07..d7573925a 100644
--- a/panels/display/cc-display-panel.c
+++ b/panels/display/cc-display-panel.c
@@ -250,14 +250,15 @@ config_ensure_of_type (CcDisplayPanel *panel, CcDisplayConfigType type)
 
     case CC_DISPLAY_CONFIG_JOIN:
       g_debug ("Creating new join config");
-      /* Enable all usable outputs */
+      /* Enable all usable outputs
+       * Note that this might result in invalid configurations as we
+       * we might not be able to drive all attached monitors. */
       cc_display_config_set_cloning (panel->current_config, FALSE);
       for (l = outputs; l; l = l->next)
         {
           CcDisplayMonitor *output = l->data;
 
           cc_display_monitor_set_active (output, cc_display_monitor_is_usable (output));
-          break;
         }
       break;