[evolution] Fix some maybe uninitialized variable usages
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Fix some maybe uninitialized variable usages
- Date: Wed, 13 Mar 2019 16:14:53 +0000 (UTC)
commit 08ea44f51b5c99bfba09b904d3cb648219462930
Author: Milan Crha <mcrha redhat com>
Date: Wed Mar 13 17:14:25 2019 +0100
Fix some maybe uninitialized variable usages
Shown with -O3 in CFLAGS.
src/e-util/e-name-selector-entry.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/e-util/e-name-selector-entry.c b/src/e-util/e-name-selector-entry.c
index b7db7be0b9..bd09abc5aa 100644
--- a/src/e-util/e-name-selector-entry.c
+++ b/src/e-util/e-name-selector-entry.c
@@ -1549,7 +1549,8 @@ insert_unichar (ENameSelectorEntry *name_selector_entry,
/* We do this so we can avoid disturbing destinations with completed contacts
* either before or after the destination being inserted. */
- get_range_at_position (text, *pos, &start_pos, &end_pos);
+ if (!get_range_at_position (text, *pos, &start_pos, &end_pos))
+ return 0;
if (*pos <= start_pos)
at_start = TRUE;
if (*pos >= end_pos)
@@ -2937,8 +2938,8 @@ popup_activate_inline_expand (ENameSelectorEntry *name_selector_entry,
}
text = gtk_entry_get_text (GTK_ENTRY (name_selector_entry));
- get_range_at_position (text, position, &start, &end);
- gtk_editable_delete_text (GTK_EDITABLE (name_selector_entry), start, end);
+ if (get_range_at_position (text, position, &start, &end))
+ gtk_editable_delete_text (GTK_EDITABLE (name_selector_entry), start, end);
gtk_editable_insert_text (GTK_EDITABLE (name_selector_entry), sanitized_text->str, -1, &start);
g_string_free (sanitized_text, TRUE);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]