[nautilus/wip/oholy/flatpak-gvfs: 5/5] flatpak: Add --share=network to fix synchronous gvfs connections

[Carlos Soriano <csoriano src gnome org>]

commit 2e38753aed90b2f9d974ba2b6525b1574a64cf6d
Author: Ondrej Holy <oholy redhat com>
Date:   Thu Mar 7 12:23:58 2019 +0100

    flatpak: Add --share=network to fix synchronous gvfs connections
    
    GVfs communicates with daemons over abstract sockets. Currently, synchronous
    GIO API doesn't work for GVfs locations, because abstract sockets seem to be
    blocked by sandbox permissions. This is not problem in most cases as Nautilus
    uses asynchronous API usually. But this breaks e.g. "Empty Trash" functionality
    as it is for some reason based on synchronous API.
    
    In order to fix this problems, it is necessary to allow access to sockets
    beginning with `unix:abstract=/dbus-vfs-daemon/socket-`, but I am not aware of
    better way than adding `--share=network`, which allows access to all abstract
    sockets:
    http://docs.flatpak.org/en/latest/sandbox-permissions-reference.html#f2
    
    Just a note that it is not clear to me, why it affects only the synchronous
    API as the asynchronous API also uses abstract sockets. See the corresponding
    Flatpak bug:
    https://github.com/flatpak/flatpak/issues/2711

 build-aux/flatpak/org.gnome.Nautilus.yml       | 1 +
 build-aux/flatpak/org.gnome.NautilusGtk4.yml   | 1 +
 build-aux/flatpak/org.gnome.NautilusMaster.yml | 1 +
 3 files changed, 3 insertions(+)
---
diff --git a/build-aux/flatpak/org.gnome.Nautilus.yml b/build-aux/flatpak/org.gnome.Nautilus.yml
index 52f8b4ac3..bcb3e3f93 100644
--- a/build-aux/flatpak/org.gnome.Nautilus.yml
+++ b/build-aux/flatpak/org.gnome.Nautilus.yml
@@ -19,6 +19,7 @@ finish-args:
 - "--filesystem=host"
 - "--talk-name=org.gtk.vfs"
 - "--talk-name=org.gtk.vfs.*"
+- "--share=network"
 - "--filesystem=xdg-run/dconf"
 - "--filesystem=~/.config/dconf:ro"
 - "--talk-name=ca.desrt.dconf"
diff --git a/build-aux/flatpak/org.gnome.NautilusGtk4.yml b/build-aux/flatpak/org.gnome.NautilusGtk4.yml
index 25b80388e..8e649ea10 100644
--- a/build-aux/flatpak/org.gnome.NautilusGtk4.yml
+++ b/build-aux/flatpak/org.gnome.NautilusGtk4.yml
@@ -19,6 +19,7 @@ finish-args:
 - "--filesystem=host"
 - "--talk-name=org.gtk.vfs"
 - "--talk-name=org.gtk.vfs.*"
+- "--share=network"
 - "--filesystem=xdg-run/dconf"
 - "--filesystem=~/.config/dconf:ro"
 - "--talk-name=ca.desrt.dconf"
diff --git a/build-aux/flatpak/org.gnome.NautilusMaster.yml b/build-aux/flatpak/org.gnome.NautilusMaster.yml
index 52f8b4ac3..bcb3e3f93 100644
--- a/build-aux/flatpak/org.gnome.NautilusMaster.yml
+++ b/build-aux/flatpak/org.gnome.NautilusMaster.yml
@@ -19,6 +19,7 @@ finish-args:
 - "--filesystem=host"
 - "--talk-name=org.gtk.vfs"
 - "--talk-name=org.gtk.vfs.*"
+- "--share=network"
 - "--filesystem=xdg-run/dconf"
 - "--filesystem=~/.config/dconf:ro"
 - "--talk-name=ca.desrt.dconf"