[gnome-games/wip/exalm/gtk4: 21/28] ui: Drop unnecessary show() and show_all() calls



commit 7f0f7a8256cef0f8598ad920fe3bb0031deb7aa5
Author: Alexander Mikhaylenko <exalm7659 gmail com>
Date:   Sun Jul 29 14:15:48 2018 +0500

    ui: Drop unnecessary show() and show_all() calls

 src/ui/application.vala                  | 2 +-
 src/ui/preferences-page-controllers.vala | 2 --
 src/ui/preferences-page-plugins.vala     | 3 ---
 3 files changed, 1 insertion(+), 6 deletions(-)
---
diff --git a/src/ui/application.vala b/src/ui/application.vala
index 24005321..7df26a10 100644
--- a/src/ui/application.vala
+++ b/src/ui/application.vala
@@ -244,7 +244,7 @@ public class Games.Application : Gtk.Application {
                window.destroy.connect (() => {
                        quit_application ();
                });
-               window.show ();
+               window.present ();
 
                GLib.Timeout.add (500, show_loading_notification);
        }
diff --git a/src/ui/preferences-page-controllers.vala b/src/ui/preferences-page-controllers.vala
index c9b3f444..96c5500d 100644
--- a/src/ui/preferences-page-controllers.vala
+++ b/src/ui/preferences-page-controllers.vala
@@ -38,7 +38,6 @@ private class Games.PreferencesPageControllers : PreferencesPage {
                        var box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
                        box.add (new Gtk.Label (device.get_name ()));
                        box.margin = 6;
-                       box.show_all ();
                        gamepads_list_box.add (box);
                }
                gamepads_label.visible = i > 0;
@@ -74,7 +73,6 @@ private class Games.PreferencesPageControllers : PreferencesPage {
                var box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
                box.add (new Gtk.Label (_("Keyboard")));
                box.margin = 6;
-               box.show_all ();
                keyboard_list_box.add (box);
        }
 
diff --git a/src/ui/preferences-page-plugins.vala b/src/ui/preferences-page-plugins.vala
index b2de3ce3..eff1339e 100644
--- a/src/ui/preferences-page-plugins.vala
+++ b/src/ui/preferences-page-plugins.vala
@@ -17,8 +17,5 @@ private class Games.PreferencesPagePlugins : PreferencesPage {
                var row = new Gtk.ListBoxRow ();
                row.add (item);
                list_box.add (row);
-
-               item.show ();
-               row.show ();
        }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]