[polari/wip/fmuellner/more-warnings: 2/3] lib: Mark unused parameters
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari/wip/fmuellner/more-warnings: 2/3] lib: Mark unused parameters
- Date: Mon, 11 Mar 2019 01:10:22 +0000 (UTC)
commit f9c16c58ee24eb8c03e6de6b937aaf321a867caf
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Mar 6 01:47:24 2019 +0100
lib: Mark unused parameters
For signal handlers and callbacks, we have to obey the method signature
of the API, so any unused parameters have a legitimate reason there and
we don't want -Wunused-parameter to warn about them.
https://gitlab.gnome.org/GNOME/polari/merge_requests/99
src/lib/polari-client-factory.c | 4 ++--
src/lib/polari-room.c | 38 +++++++++++++++++++-------------------
2 files changed, 21 insertions(+), 21 deletions(-)
---
diff --git a/src/lib/polari-client-factory.c b/src/lib/polari-client-factory.c
index 18ebb08..41f281d 100644
--- a/src/lib/polari-client-factory.c
+++ b/src/lib/polari-client-factory.c
@@ -51,7 +51,7 @@ polari_client_factory_create_account (PolariClientFactory *self,
static TpAccount *
polari_client_factory_create_account_impl (TpSimpleClientFactory *self,
const char *object_path,
- const GHashTable *immutable_props,
+ const GHashTable *immutable_props G_GNUC_UNUSED,
GError **error)
{
return polari_client_factory_create_account (POLARI_CLIENT_FACTORY (self),
@@ -68,6 +68,6 @@ polari_client_factory_class_init (PolariClientFactoryClass *klass)
}
static void
-polari_client_factory_init (PolariClientFactory *self)
+polari_client_factory_init (PolariClientFactory *self G_GNUC_UNUSED)
{
}
diff --git a/src/lib/polari-room.c b/src/lib/polari-room.c
index 4ddc668..dc686e5 100644
--- a/src/lib/polari-room.c
+++ b/src/lib/polari-room.c
@@ -392,19 +392,19 @@ update_icon (PolariRoom *room)
}
static void
-on_self_contact_notify (GObject *object,
- GParamSpec *pspec,
+on_self_contact_notify (GObject *object G_GNUC_UNUSED,
+ GParamSpec *pspec G_GNUC_UNUSED,
gpointer user_data)
{
update_self_nick (POLARI_ROOM (user_data));
}
static void
-on_group_contacts_changed (TpChannel *channel,
+on_group_contacts_changed (TpChannel *channel G_GNUC_UNUSED,
GPtrArray *added,
GPtrArray *removed,
- GPtrArray *local_pending,
- GPtrArray *remote_pending,
+ GPtrArray *local_pending G_GNUC_UNUSED,
+ GPtrArray *remote_pending G_GNUC_UNUSED,
TpContact *actor,
GHashTable *details,
gpointer user_data)
@@ -473,10 +473,10 @@ on_group_contacts_changed (TpChannel *channel,
}
static void
-on_message_sent (TpTextChannel *channel,
+on_message_sent (TpTextChannel *channel G_GNUC_UNUSED,
TpSignalledMessage *message,
- guint flags,
- char *token,
+ guint flags G_GNUC_UNUSED,
+ char *token G_GNUC_UNUSED,
gpointer user_data)
{
PolariRoom *room = user_data;
@@ -498,10 +498,10 @@ on_message_sent (TpTextChannel *channel,
}
static void
-on_channel_invalidated (TpProxy *channel,
- guint domain,
- int code,
- char *message,
+on_channel_invalidated (TpProxy *channel G_GNUC_UNUSED,
+ guint domain G_GNUC_UNUSED,
+ int code G_GNUC_UNUSED,
+ char *message G_GNUC_UNUSED,
gpointer user_data)
{
polari_room_set_channel (POLARI_ROOM (user_data), NULL);
@@ -531,11 +531,11 @@ update_subject (PolariRoom *room,
}
static void
-subject_get_all (TpProxy *proxy,
- GHashTable *properties,
+subject_get_all (TpProxy *proxy G_GNUC_UNUSED,
+ GHashTable *properties G_GNUC_UNUSED,
const GError *error,
gpointer user_data,
- GObject *object)
+ GObject *object G_GNUC_UNUSED)
{
if (error)
return;
@@ -544,12 +544,12 @@ subject_get_all (TpProxy *proxy,
}
static void
-properties_changed (TpProxy *proxy,
+properties_changed (TpProxy *proxy G_GNUC_UNUSED,
const char *iface_name,
GHashTable *changed,
- const char **invalidated,
+ const char **invalidated G_GNUC_UNUSED,
gpointer data,
- GObject *weak_ref)
+ GObject *weak_ref G_GNUC_UNUSED)
{
if (strcmp (iface_name, TP_IFACE_CHANNEL_INTERFACE_SUBJECT) != 0)
return;
@@ -559,7 +559,7 @@ properties_changed (TpProxy *proxy,
static void
on_contact_info_ready (GObject *source,
- GAsyncResult *res,
+ GAsyncResult *res G_GNUC_UNUSED,
gpointer data)
{
PolariRoom *room = data;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]