[librsvg] Loader: remove the unimplemented read() method
- From: Federico Mena Quintero <federico src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [librsvg] Loader: remove the unimplemented read() method
- Date: Fri, 8 Mar 2019 01:25:46 +0000 (UTC)
commit becef48eda36be94bcdd60bd36258c89099e50cd
Author: Federico Mena Quintero <federico gnome org>
Date: Thu Mar 7 19:08:28 2019 -0600
Loader: remove the unimplemented read() method
This is intended to read from a &dyn Read, but we don't have either of
these yet:
* A wrapper that takes a Read and exposes a GInputStream (would be
generally useful for gio)
* Xml2Parser::from_read() akin to Xml2Parser::from_stream(). This
involves implementing the libxml2 I/O callbacks in terms of a Read,
which should be pretty easy.
librsvg_crate/src/lib.rs | 15 ---------------
1 file changed, 15 deletions(-)
---
diff --git a/librsvg_crate/src/lib.rs b/librsvg_crate/src/lib.rs
index a7741baf..5366e0b2 100644
--- a/librsvg_crate/src/lib.rs
+++ b/librsvg_crate/src/lib.rs
@@ -239,21 +239,6 @@ impl Loader {
self.read_file(&file, None)
}
- /// Reads an SVG stream from something implementing [`Read`][Read].
- ///
- /// Reading an SVG file may involve resolving relative URLs if the
- /// SVG references things like raster images, or other SVG files.
- /// In this case, pass the `base_url` that represents the URL
- /// where this SVG got loaded from.
- ///
- /// FIXME: example
- ///
- /// [Read]: https://doc.rust-lang.org/stable/std/io/trait.Read.html
- pub fn read(self, _r: &dyn Read, _base_url: Option<&Url>) -> Result<SvgHandle, LoadingError> {
- // This requires wrapping a Read with a GInputStream
- unimplemented!();
- }
-
/// Reads an SVG file from a `gio::File`.
///
/// The `cancellable` can be used to cancel loading from another thread.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]