[epiphany/mcatanzaro/passwords: 35/35] ephy.js: Further improve and/or remove misleading error messages



commit 2cc47066cccf35ab9359204253d661cfbcb31bce
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Sun Mar 3 19:18:03 2019 -0600

    ephy.js: Further improve and/or remove misleading error messages
    
    In an earlier commit, I fixed the last error message here, without
    noticing that the other two are wrong too. Let's just keep the first
    one. These log messages are not very useful when debugging why password
    autofill isn't working and having one saved username is the
    expected/ordinary case, so let's only log when multiple are found.
    
    Note the first log message here is wrong because we are looking at
    usernames, not passwords, and the second is wrong because there could
    be zero usernames found. (And the third was wrong before I got to it
    recently.)

 embed/web-extension/resources/js/ephy.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
---
diff --git a/embed/web-extension/resources/js/ephy.js b/embed/web-extension/resources/js/ephy.js
index 1fa0361e8..a2e125882 100644
--- a/embed/web-extension/resources/js/ephy.js
+++ b/embed/web-extension/resources/js/ephy.js
@@ -436,16 +436,12 @@ Ephy.FormManager = class FormManager
         if (formAuth.usernameNode) {
             Ephy.passwordManager.queryUsernames(formAuth.origin).then((users) => {
                 if (users.length > 1) {
-                    Ephy.log('More than one password saved, hooking menu for choosing which on focus');
+                    Ephy.log('More than one saved username, hooking menu for choosing which one to select');
                     this._preFillUserMenu = new Ephy.PreFillUserMenu(this, formAuth.usernameNode, users, 
formAuth.passwordNode);
-                } else {
-                    Ephy.log('Single item in username list, not hooking menu for choosing.');
                 }
-
                 this.preFill(formAuth);
             });
         } else {
-            Ephy.log('No username field, not hooking menu for choosing.');
             this.preFill(formAuth);
         }
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]