[epiphany/mcatanzaro/passwords: 26/35] ephy.js: Remove nonsense check



commit 627169c1c0c9e19e7c30e68ef16d8a6d9db83bbd
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Sun Mar 3 15:59:30 2019 -0600

    ephy.js: Remove nonsense check
    
    Doesn't make sense to null-check a variable that we are about to
    overwrite. This was causing us to skip checking for form auth elements
    when submitting a form if we didn't previously receive a useful formAuth
    when the form element was created.

 embed/web-extension/resources/js/ephy.js | 3 ---
 1 file changed, 3 deletions(-)
---
diff --git a/embed/web-extension/resources/js/ephy.js b/embed/web-extension/resources/js/ephy.js
index 9a3a3d175..d6cebb5fc 100644
--- a/embed/web-extension/resources/js/ephy.js
+++ b/embed/web-extension/resources/js/ephy.js
@@ -483,9 +483,6 @@ Ephy.FormManager = class FormManager
 
     handleFormSubmission()
     {
-        if (!this._formAuth)
-            return;
-
         this._formAuth = this._generateFormAuth(false);
         if (!this._formAuth)
             return;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]