[gnome-software] details page: Fix item spacing when the developer isn't set



commit ac10dd25235082e50ed47b79deab6e0ed2f7f133
Author: Kalev Lember <klember redhat com>
Date:   Tue Mar 5 13:22:51 2019 +0100

    details page: Fix item spacing when the developer isn't set
    
    Make sure we hide the developer box as well, not just the label that's
    inside.

 src/gs-details-page.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 05fdf693..9e1b7274 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -92,6 +92,7 @@ struct _GsDetailsPage
        GtkWidget               *label_details_category_value;
        GtkWidget               *label_details_developer_title;
        GtkWidget               *label_details_developer_value;
+       GtkWidget               *box_details_developer;
        GtkWidget               *image_details_developer_verified;
        GtkWidget               *button_details_license_free;
        GtkWidget               *button_details_license_nonfree;
@@ -1108,11 +1109,11 @@ gs_details_page_refresh_all (GsDetailsPage *self)
                tmp = gs_app_get_project_group (self->app);
        if (tmp == NULL) {
                gtk_widget_set_visible (self->label_details_developer_title, FALSE);
-               gtk_widget_set_visible (self->label_details_developer_value, FALSE);
+               gtk_widget_set_visible (self->box_details_developer, FALSE);
        } else {
                gtk_widget_set_visible (self->label_details_developer_title, TRUE);
                gtk_label_set_label (GTK_LABEL (self->label_details_developer_value), tmp);
-               gtk_widget_set_visible (self->label_details_developer_value, TRUE);
+               gtk_widget_set_visible (self->box_details_developer, TRUE);
        }
        gtk_widget_set_visible (self->image_details_developer_verified, gs_app_has_quirk (self->app, 
GS_APP_QUIRK_DEVELOPER_VERIFIED));
 
@@ -2698,6 +2699,7 @@ gs_details_page_class_init (GsDetailsPageClass *klass)
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_category_value);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_developer_title);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_developer_value);
+       gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, box_details_developer);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, image_details_developer_verified);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, button_details_license_free);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, button_details_license_nonfree);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]