[tracker/wip/carlosg/trigger-filter-parent-on-monitor-events: 1/3] libtracker-miner: Do not check indexing tree on monitor events



commit 0f43ce3cf99b56f92323bf7d06da84d41cca2a96
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Mar 2 23:54:24 2019 +0100

    libtracker-miner: Do not check indexing tree on monitor events
    
    Leave all checks on TrackerIndexingTree to the TrackerFileNotifier,
    and report all events to it. Those might trigger other actions
    (eg. policy changes through the TrackerIndexingTree) that shouldn't
    go ignored.

 src/libtracker-miner/tracker-monitor.c | 29 -----------------------------
 1 file changed, 29 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-monitor.c b/src/libtracker-miner/tracker-monitor.c
index 26aa8b877..d7c0a3482 100644
--- a/src/libtracker-miner/tracker-monitor.c
+++ b/src/libtracker-miner/tracker-monitor.c
@@ -670,17 +670,6 @@ monitor_event_cb (GFileMonitor      *file_monitor,
        if (!other_file) {
                is_directory = check_is_directory (monitor, file);
 
-               /* Avoid non-indexable-files */
-               if (priv->tree &&
-                   !tracker_indexing_tree_file_is_indexable (priv->tree,
-                                                             file,
-                                                             (is_directory ?
-                                                              G_FILE_TYPE_DIRECTORY :
-                                                              G_FILE_TYPE_REGULAR))) {
-                       g_free (file_uri);
-                       return;
-               }
-
                other_file_uri = NULL;
                g_debug ("Received monitor event:%d (%s) for %s:'%s'",
                         event_type,
@@ -695,24 +684,6 @@ monitor_event_cb (GFileMonitor      *file_monitor,
                        is_directory = check_is_directory (monitor, file);
                }
 
-               /* Avoid doing anything of both
-                * file/other_file are non-indexable
-                */
-               if (priv->tree &&
-                   !tracker_indexing_tree_file_is_indexable (priv->tree,
-                                                             file,
-                                                             (is_directory ?
-                                                              G_FILE_TYPE_DIRECTORY :
-                                                              G_FILE_TYPE_REGULAR)) &&
-                   !tracker_indexing_tree_file_is_indexable (priv->tree,
-                                                             other_file,
-                                                             (is_directory ?
-                                                              G_FILE_TYPE_DIRECTORY :
-                                                              G_FILE_TYPE_REGULAR))) {
-                       g_free (file_uri);
-                       return;
-               }
-
                other_file_uri = g_file_get_uri (other_file);
                g_debug ("Received monitor event:%d (%s) for files '%s'->'%s'",
                         event_type,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]