[meld/ui-next] meldwindow: Log when we fail to open a recent file



commit d142b200d6755d6e9946321afe80a7708d731841
Author: Kai Willadsen <kai willadsen gmail com>
Date:   Tue Feb 19 07:27:54 2019 +1000

    meldwindow: Log when we fail to open a recent file

 meld/meldwindow.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/meld/meldwindow.py b/meld/meldwindow.py
index c7942a1d..42886467 100644
--- a/meld/meldwindow.py
+++ b/meld/meldwindow.py
@@ -14,6 +14,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import logging
 import os
 
 from gi.repository import Gdk
@@ -35,6 +36,8 @@ from meld.ui.notebooklabel import NotebookLabel
 from meld.vcview import VcView
 from meld.windowstate import SavedWindowState
 
+log = logging.getLogger(__name__)
+
 
 @Template(resource_path='/org/gnome/meld/ui/appwindow.ui')
 class MeldWindow(Gtk.ApplicationWindow):
@@ -393,7 +396,7 @@ class MeldWindow(Gtk.ApplicationWindow):
             self.append_recent(uri)
         except (IOError, ValueError):
             # FIXME: Need error handling, but no sensible display location
-            pass
+            log.exception(f'Error opening recent file {uri}')
 
     def on_menu_close_activate(self, *extra):
         i = self.notebook.get_current_page()


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]