[tracker/wip/carlosg/double-precision: 1/4] libtracker-data: Do not cast doubles to strings



commit 59db5202f8e1dc5c4f656585a1504d760364439f
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Mar 2 17:37:51 2019 +0100

    libtracker-data: Do not cast doubles to strings
    
    Letting Sqlite handle the conversion may result in precision loss,
    weird ordering, and possibly other side results.

 src/libtracker-data/tracker-sparql.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/libtracker-data/tracker-sparql.c b/src/libtracker-data/tracker-sparql.c
index 6abdffe28..2a7f78181 100644
--- a/src/libtracker-data/tracker-sparql.c
+++ b/src/libtracker-data/tracker-sparql.c
@@ -1369,8 +1369,9 @@ convert_expression_to_string (TrackerSparql       *sparql,
        switch (type) {
        case TRACKER_PROPERTY_TYPE_STRING:
        case TRACKER_PROPERTY_TYPE_INTEGER:
-               /* Nothing to convert. Do not use CAST to convert integers to
-                * strings as this breaks use of index when sorting by variable
+       case TRACKER_PROPERTY_TYPE_DOUBLE:
+               /* Nothing to convert. Do not use CAST to convert integer/double to
+                * to string as this breaks use of index when sorting by variable
                 * introduced in select expression
                 */
                break;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]