[gnome-initial-setup: 2/4] summary: Fix memory leak
- From: Will Thompson <wjt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-initial-setup: 2/4] summary: Fix memory leak
- Date: Fri, 1 Mar 2019 15:14:44 +0000 (UTC)
commit 7afc541471eb949cba1111196106f59464c7da66
Author: João Paulo Rechi Vita <jprvita endlessm com>
Date: Tue Nov 27 12:11:30 2018 -0800
summary: Fix memory leak
This commit fixes leaking a GError in log_user_in. While at it, also
initializes a couple of pointers to NULL on declaration, and changes
another GError to use g_autoptr.
gnome-initial-setup/pages/summary/gis-summary-page.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
---
diff --git a/gnome-initial-setup/pages/summary/gis-summary-page.c
b/gnome-initial-setup/pages/summary/gis-summary-page.c
index 4686533..875f603 100644
--- a/gnome-initial-setup/pages/summary/gis-summary-page.c
+++ b/gnome-initial-setup/pages/summary/gis-summary-page.c
@@ -126,17 +126,15 @@ add_uid_file (uid_t uid)
{
gchar *gis_uid_path;
gchar *uid_str;
- GError *error = NULL;
+ g_autoptr(GError) error = NULL;
gis_uid_path = g_build_filename (g_get_home_dir (),
"gnome-initial-setup-uid",
NULL);
uid_str = g_strdup_printf ("%u", uid);
- if (!g_file_set_contents (gis_uid_path, uid_str, -1, &error)) {
+ if (!g_file_set_contents (gis_uid_path, uid_str, -1, &error))
g_warning ("Unable to create %s: %s", gis_uid_path, error->message);
- g_clear_error (&error);
- }
g_free (uid_str);
g_free (gis_uid_path);
@@ -146,9 +144,9 @@ static void
log_user_in (GisSummaryPage *page)
{
GisSummaryPagePrivate *priv = gis_summary_page_get_instance_private (page);
- GError *error = NULL;
- GdmGreeter *greeter;
- GdmUserVerifier *user_verifier;
+ g_autoptr(GError) error = NULL;
+ GdmGreeter *greeter = NULL;
+ GdmUserVerifier *user_verifier = NULL;
if (!gis_driver_get_gdm_objects (GIS_PAGE (page)->driver,
&greeter, &user_verifier)) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]