[gnome-shell/wip/fix-busy-loop: 2/2] animation: fix unintentional loop while polkit dialog is active

[Ray Strode <halfline src gnome org>]

commit eb3a584769dda8cd7121217e5cdd0f50f33b66db
Author: Ray Strode <rstrode redhat com>
Date:   Thu Jun 27 14:27:34 2019 -0400

    animation: fix unintentional loop while polkit dialog is active
    
    The polkit password dialog has a spinner that gets displayed
    while the users password is being verified.
    
    Unfortunately, the spinner stop method unintentionally calls
    back into itself after the stop fade out animation is complete.
    The stop method is called at startup, so the looping begins as
    soon as the dialog is visible and continues until the dialog is
    dismissed.
    
    This commit fixes the loop by having the stop method cease
    calling itself, and instead having it call the stop method on the
    superclass.

 js/ui/animation.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/animation.js b/js/ui/animation.js
index c21b22565..58d7f4018 100644
--- a/js/ui/animation.js
+++ b/js/ui/animation.js
@@ -162,7 +162,7 @@ var Spinner = class extends AnimatedIcon {
                 time: SPINNER_ANIMATION_TIME,
                 transition: 'linear',
                 onComplete: () => {
-                    this.stop(false);
+                    super.stop();
                 }
             });
         } else {