[odrs-web] Fix some pylint warnings

[Richard Hughes <rhughes src gnome org>]

commit d1e2f61597e3b9d9f5e6f8d3347ecfad81dc6c6d
Author: Richard Hughes <richard hughsie com>
Date:   Sun Feb 10 13:19:51 2019 +0000

    Fix some pylint warnings

 app_data/app/views.py       | 6 ++----
 app_data/app/views_admin.py | 8 ++++----
 2 files changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/app_data/app/views.py b/app_data/app/views.py
index 831f606..7abb3df 100644
--- a/app_data/app/views.py
+++ b/app_data/app/views.py
@@ -17,7 +17,7 @@ from flask_login import login_user, logout_user
 from app import app, get_db
 
 from .db import CursorError
-from .models import Review, Moderator
+from .models import Review
 
 def _get_user_key(user_hash, app_id):
     salt = os.environ['ODRS_REVIEWS_SECRET']
@@ -119,8 +119,6 @@ def _sanitised_version(val):
 def login():
     if request.method != 'POST':
         return render_template('login.html')
-    username = request.form['username']
-    password = request.form['password']
     try:
         db = get_db()
         user = db.moderators.get_by_username_password(request.form['username'],
@@ -321,7 +319,7 @@ def fetch():
             return json_error('invalid data, expected %s' % key)
         if item[key] is None:
             return json_error('missing data, expected %s' % key)
-        if item[key] is '':
+        if item[key] == '':
             return json_error('missing data, expected %s' % key)
 
     # check format
diff --git a/app_data/app/views_admin.py b/app_data/app/views_admin.py
index f2a6672..bd8dc86 100644
--- a/app_data/app/views_admin.py
+++ b/app_data/app/views_admin.py
@@ -210,9 +210,9 @@ def utility_processor():
     def format_rating(rating):
         nr_stars = int(rating / 20)
         tmp = ''
-        for i in range(0, nr_stars):
+        for _ in range(0, nr_stars):
             tmp += u'★'
-        for i in range(0, 5 - nr_stars):
+        for _ in range(0, 5 - nr_stars):
             tmp += u'☆'
         return tmp
 
@@ -636,9 +636,9 @@ def admin_vote(review_id, val_str):
     if val_str == 'up':
         val = 1
     elif val_str == 'down':
-        val = -1;
+        val = -1
     elif val_str == 'meh':
-        val = 0;
+        val = 0
     else:
         return _error_internal('invalid vote value...')
     try: