[gtkmm/wip/dboles/Gdk_ImageSurface: 1/4] Cursor: Fix meaning of comment about Cairo ref arg



commit 769933b202813b35b7f0448e850d4823f3fbd8aa
Author: Daniel Boles <dboles src gmail com>
Date:   Thu Jun 20 18:38:44 2019 +0100

    Cursor: Fix meaning of comment about Cairo ref arg
    
    Cairo::Object takes a has_reference parameter, not take_copy with
    inverted meaning as in glibmm/gtkmm.
    
    Say "do not take ref" like e.g. window.hg already did, which is a bit
    clearer than has_reference (when does it get that? before or after us?)
    
    https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/19#note_535429
    https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/19#note_536603

 gdk/src/cursor.hg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gdk/src/cursor.hg b/gdk/src/cursor.hg
index ab6ab4cd..fd96b2c1 100644
--- a/gdk/src/cursor.hg
+++ b/gdk/src/cursor.hg
@@ -64,8 +64,8 @@ public:
   _WRAP_METHOD(Glib::RefPtr<const Gdk::Pixbuf> get_image() const, gdk_cursor_get_image, constversion)
 
   //TODO: Should this always be const?
-#m4 _CONVERSION(`cairo_surface_t*',`::Cairo::RefPtr< ::Cairo::Surface>',`::Cairo::RefPtr< 
::Cairo::Surface>(new ::Cairo::Surface($3, true /* take reference */))')
-#m4 _CONVERSION(`cairo_surface_t*',`::Cairo::RefPtr<const ::Cairo::Surface>',`::Cairo::RefPtr< 
::Cairo::Surface>(new ::Cairo::Surface($3, true /* take reference */))')
+#m4 _CONVERSION(`cairo_surface_t*',`::Cairo::RefPtr< ::Cairo::Surface>',`::Cairo::RefPtr< 
::Cairo::Surface>(new ::Cairo::Surface($3, true /* do not take ref */))')
+#m4 _CONVERSION(`cairo_surface_t*',`::Cairo::RefPtr<const ::Cairo::Surface>',`::Cairo::RefPtr< 
::Cairo::Surface>(new ::Cairo::Surface($3, true /* do not take ref */))')
   _WRAP_METHOD(::Cairo::RefPtr< ::Cairo::Surface> get_surface(double& x_hot, double& y_hot), 
gdk_cursor_get_surface)
   _WRAP_METHOD(::Cairo::RefPtr<const ::Cairo::Surface> get_surface(double& x_hot, double& y_hot) const, 
gdk_cursor_get_surface, constversion)
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]